sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BaseTools/C/Common: Add checks for array access

Browse Source 
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
This commit is contained in:
Hao Wu
2017-11-30 14:29:25 +08:00
parent 5e125e7752
commit 58356e9478
2 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
BaseTools/Source/C/Common/SimpleFileParsing.c
View File

@ -1,7 +1,7 @@
/** @file
Generic but simple file parsing routines.
Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.<BR>
Copyright (c) 2004 - 2017, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@ -1232,12 +1232,10 @@ GetHexChars (
{
UINT32 Len;
Len = 0;
while (!EndOfFile (&mGlobals.SourceFile) && (BufferLen > 0)) {
while (!EndOfFile (&mGlobals.SourceFile) && (Len < BufferLen)) {
if (isxdigit ((int)mGlobals.SourceFile.FileBufferPtr[0])) {
*Buffer = mGlobals.SourceFile.FileBufferPtr[0];
Buffer++;
Buffer[Len] = mGlobals.SourceFile.FileBufferPtr[0];
Len++;
BufferLen--;
mGlobals.SourceFile.FileBufferPtr++;
} else {
break;
@ -1246,8 +1244,8 @@ GetHexChars (
//
// Null terminate if we can
//
if ((Len > 0) && (BufferLen > 0)) {
*Buffer = 0;
if ((Len > 0) && (Len < BufferLen)) {
Buffer[Len] = 0;
}
return Len;