sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

DynamicTablesPkg: AmlLib fix ECC errors

Browse Source 
Fix the following ECC reported errors in AmlLib.
  - [1008]  File has invalid Non-ACSII char.
  - [9002]  The function headers should follow Doxygen special
            documentation blocks in section 2.3.5 Comment does NOT
            have tail **/

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
This commit is contained in:
Sami Mujawar
2020-09-21 18:08:56 +01:00
committed by mergify[bot]
parent e4dfb2ffa3
commit 5e0b708f74
10 changed files with 19 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListParser.c
View File

@@ -41,7 +41,7 @@
@retval EFI_BUFFER_TOO_SMALL No space left in the buffer.
@retval EFI_INVALID_PARAMETER Invalid parameter.
@retval EFI_OUT_OF_RESOURCES Could not allocate memory.
*/
**/
STATIC
EFI_STATUS
EFIAPI
@@ -177,7 +177,7 @@ AmlParseFieldElement (
@retval EFI_BUFFER_TOO_SMALL No space left in the buffer.
@retval EFI_INVALID_PARAMETER Invalid parameter.
@retval EFI_OUT_OF_RESOURCES Could not allocate memory.
*/
**/
STATIC
EFI_STATUS
EFIAPI

6
DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c
View File

@@ -1320,7 +1320,7 @@ AmlCreateMethodInvocationNode (
// DefExternal := ExternalOp NameString ObjectType ArgumentCount
// ExternalOp := 0x15
// ObjectType := ByteData
// ArgumentCount := ByteData (0 – 7)
// ArgumentCount := ByteData (0 - 7)
// Read the ArgumentCount.
ArgCountNode = (AML_DATA_NODE*)FixedArgs[EAmlParseIndexTerm2];
@@ -1334,7 +1334,7 @@ AmlCreateMethodInvocationNode (
// MethodInvocation := MethodInvocationOp NameString ArgumentCount
// MethodInvocationOp := Pseudo Opcode for Method Invocation
// NameString := Method Name
// ArgumentCount := ByteData (0 – 7)
// ArgumentCount := ByteData (0 - 7)
Status = AmlCreateObjectNode (
AmlGetByteEncodingByOpCode (AML_METHOD_INVOC_OP, 0),
0,
@@ -1411,7 +1411,7 @@ error_handler:
@retval EFI_BUFFER_TOO_SMALL No space left in the buffer.
@retval EFI_INVALID_PARAMETER Invalid parameter.
@retval EFI_OUT_OF_RESOURCES Could not allocate memory.
*/
**/
EFI_STATUS
EFIAPI
AmlGetMethodInvocationArgCount (

6
DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c
View File

@@ -1134,7 +1134,7 @@ AmlParseVariableArguments (
@retval EFI_BUFFER_TOO_SMALL No space left in the buffer.
@retval EFI_INVALID_PARAMETER Invalid parameter.
@retval EFI_OUT_OF_RESOURCES Could not allocate memory.
*/
**/
STATIC
EFI_STATUS
EFIAPI
@@ -1179,7 +1179,7 @@ AmlPopulateRootNode (
@retval EFI_BUFFER_TOO_SMALL No space left in the buffer.
@retval EFI_INVALID_PARAMETER Invalid parameter.
@retval EFI_OUT_OF_RESOURCES Could not allocate memory.
*/
**/
STATIC
EFI_STATUS
EFIAPI
@@ -1287,7 +1287,7 @@ AmlPopulateObjectNode (
@retval EFI_BUFFER_TOO_SMALL No space left in the buffer.
@retval EFI_INVALID_PARAMETER Invalid parameter.
@retval EFI_OUT_OF_RESOURCES Could not allocate memory.
*/
**/
STATIC
EFI_STATUS
EFIAPI

2
DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataParser.c
View File

@@ -213,7 +213,7 @@ AmlRdIsResourceDataBuffer (
return TRUE;
}
// TODO Might want to check the CRC when available.
// @todo Might want to check the CRC when available.
// An end tag resource data element must be the last element of the list.
// Thus the function should have already returned.
if (AmlRdCompareDescId (