sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ShellPkg/UefiShellDriver1CommandsLib: fix parameter list typo

Browse Source 
The ShellCommandRunConnect() function passes EFI_HANDLE -- (VOID*) --
objects to ConvertAndConnectControllers(), and
ConvertAndConnectControllers() passes those to gBS->OpenProtocol().

Accordingly, ConvertAndConnectControllers() should specify EFI_HANDLE
parameter types, not (EFI_HANDLE*) -- (VOID**) -- types.

This typo is masked because (VOID*) converts to and from any
pointer-to-object type silently.

Note that functionally speaking there is no problem, so this patch does
not change beavior, only cleans up the code.

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
This commit is contained in:
Laszlo Ersek
2019-09-06 22:02:06 +02:00
parent fcf8bdcd53
commit 61d505dfc1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c
View File

@ -346,8 +346,8 @@ ShellConnectFromDevPaths (
**/ **/
EFI_STATUS EFI_STATUS
ConvertAndConnectControllers ( ConvertAndConnectControllers (
IN EFI_HANDLE *Handle1 OPTIONAL, IN EFI_HANDLE Handle1 OPTIONAL,
IN EFI_HANDLE *Handle2 OPTIONAL, IN EFI_HANDLE Handle2 OPTIONAL,
IN CONST BOOLEAN Recursive, IN CONST BOOLEAN Recursive,
IN CONST BOOLEAN Output IN CONST BOOLEAN Output
) )