sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

SecurityPkg/OpalPassword: Fix PSID revert no hint message.

Browse Source 
For no warning message when do the PSID revert action, the
message in the popup dialog is not enough. The error use
of NULL for CreatePopUp function caused this regression.
This change fixed it.

Passed Unit Test:
1. Check PSID revert with/without warning message cases.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
This commit is contained in:
Eric Dong
2018-05-14 15:28:40 +08:00
parent 5a1d521dee
commit 63c76537c6
1 changed files with 20 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
View File

@@ -687,15 +687,26 @@ OpalDriverPopUpPsidInput (
InputLength = 0; InputLength = 0;
while (TRUE) { while (TRUE) {
Mask[InputLength] = L'_'; Mask[InputLength] = L'_';
CreatePopUp ( if (PopUpString2 == NULL) {
EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE, CreatePopUp (
&InputKey, EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,
PopUpString, &InputKey,
PopUpString2, PopUpString,
L"---------------------", L"---------------------",
Mask, Mask,
NULL NULL
); );
} else {
CreatePopUp (
EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,
&InputKey,
PopUpString,
PopUpString2,
L"---------------------",
Mask,
NULL
);
}
// //
// Check key. // Check key.