sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

NetworkPkg: Remove redundant check in PXE driver.

Browse Source 
The IP protocol has been configured to only receive ICMP packet in PXE driver.
So this patch removes the unnecessary check for NextHeader field and replace it
with ASSERT.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>
This commit is contained in:
Fu Siyuan
2017-12-21 15:31:22 +08:00
parent c7285227e7
commit 673abfb749
1 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c
View File

@@ -279,14 +279,11 @@ PxeBcIcmpErrorDpcHandle (
gBS->SignalEvent (RxData->RecycleSignal); gBS->SignalEvent (RxData->RecycleSignal);
goto ON_EXIT; goto ON_EXIT;
} }
if (RxData->Header->Protocol != EFI_IP_PROTO_ICMP) { //
// // The protocol has been configured to only receive ICMP packet.
// The protocol value in the header of the receveid packet should be EFI_IP_PROTO_ICMP. //
// ASSERT (RxData->Header->Protocol == EFI_IP_PROTO_ICMP);
gBS->SignalEvent (RxData->RecycleSignal);
goto ON_EXIT;
}
Type = *((UINT8 *) RxData->FragmentTable[0].FragmentBuffer); Type = *((UINT8 *) RxData->FragmentTable[0].FragmentBuffer);
@@ -416,13 +413,10 @@ PxeBcIcmp6ErrorDpcHandle (
goto ON_EXIT; goto ON_EXIT;
} }
if (RxData->Header->NextHeader != IP6_ICMP) { //
// // The protocol has been configured to only receive ICMP packet.
// The nextheader in the header of the receveid packet should be IP6_ICMP. //
// ASSERT (RxData->Header->NextHeader == IP6_ICMP);
gBS->SignalEvent (RxData->RecycleSignal);
goto ON_EXIT;
}
Type = *((UINT8 *) RxData->FragmentTable[0].FragmentBuffer); Type = *((UINT8 *) RxData->FragmentTable[0].FragmentBuffer);