Remove SafeFreePool from MemoryAllocationLib as this API's name is misleading. Its implementation only check if a pointer is NULL. If a garbage pointer is passed in, the gBS->FreePool will still ASSERT in debug build and return error code.

It is recommended that module writer should keep track how a pointer is allocated and free it after use.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6306 6f19259b-4bc3-4df7-8a09-765794883524

MdeModulePkg/Universal/BdsDxe/BootMaint/UpdatePage.c

@@ -549,7 +549,7 @@ UpdateOrderPage (
       );
   }
 
-  SafeFreePool (IfrOptionList);
+  FreePool (IfrOptionList);
 
   UpdatePageEnd (CallbackData);
 
@@ -626,7 +626,7 @@ UpdateBootNextPage (
       &gUpdateData
       );
 
-    SafeFreePool (IfrOptionList);
+    FreePool (IfrOptionList);
   }
 
   UpdatePageEnd (CallbackData);
@@ -771,8 +771,8 @@ UpdateConModePage (
     ValidMode,
     &gUpdateData
     );
-  SafeFreePool (IfrOptionList);
-  SafeFreePool (ModeToken);
+  FreePool (IfrOptionList);
+  FreePool (ModeToken);
 
   UpdatePageEnd (CallbackData);
 }
@@ -946,7 +946,7 @@ UpdateTerminalPage (
     &gUpdateData
     );
 
-  SafeFreePool (IfrOptionList);
+  FreePool (IfrOptionList);
 
   UpdatePageEnd (CallbackData);
 }
@@ -1063,14 +1063,14 @@ GetLegacyBootOptionVar (
         (BBS_BBS_DP == DevicePath->SubType)
         ) {
       *OptionIndex = OrderBuffer[Index];
-      SafeFreePool (OrderBuffer);
+      FreePool (OrderBuffer);
       return OptionBuffer;
     } else {
-      SafeFreePool (OptionBuffer);
+      FreePool (OptionBuffer);
     }
   }
 
-  SafeFreePool (OrderBuffer);
+  FreePool (OrderBuffer);
   return NULL;
 }
 
@@ -1271,7 +1271,7 @@ UpdateSetLegacyDeviceOrderPage (
   CopyMem (OldData, LegacyOrder, 100);
 
   if (IfrOptionList != NULL) {
-    SafeFreePool (IfrOptionList);
+    FreePool (IfrOptionList);
     IfrOptionList = NULL;
   }