Remove SafeFreePool from MemoryAllocationLib as this API's name is misleading. Its implementation only check if a pointer is NULL. If a garbage pointer is passed in, the gBS->FreePool will still ASSERT in debug build and return error code.
It is recommended that module writer should keep track how a pointer is allocated and free it after use. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6306 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
@@ -611,34 +611,34 @@ FreeBrowserStrings (
|
||||
VOID
|
||||
)
|
||||
{
|
||||
SafeFreePool (gFunctionOneString);
|
||||
SafeFreePool (gFunctionTwoString);
|
||||
SafeFreePool (gFunctionNineString);
|
||||
SafeFreePool (gFunctionTenString);
|
||||
SafeFreePool (gEnterString);
|
||||
SafeFreePool (gEnterCommitString);
|
||||
SafeFreePool (gEscapeString);
|
||||
SafeFreePool (gMoveHighlight);
|
||||
SafeFreePool (gMakeSelection);
|
||||
SafeFreePool (gDecNumericInput);
|
||||
SafeFreePool (gHexNumericInput);
|
||||
SafeFreePool (gToggleCheckBox);
|
||||
SafeFreePool (gPromptForData);
|
||||
SafeFreePool (gPromptForPassword);
|
||||
SafeFreePool (gPromptForNewPassword);
|
||||
SafeFreePool (gConfirmPassword);
|
||||
SafeFreePool (gPassowordInvalid);
|
||||
SafeFreePool (gConfirmError);
|
||||
SafeFreePool (gPressEnter);
|
||||
SafeFreePool (gEmptyString);
|
||||
SafeFreePool (gAreYouSure);
|
||||
SafeFreePool (gYesResponse);
|
||||
SafeFreePool (gNoResponse);
|
||||
SafeFreePool (gMiniString);
|
||||
SafeFreePool (gPlusString);
|
||||
SafeFreePool (gMinusString);
|
||||
SafeFreePool (gAdjustNumber);
|
||||
SafeFreePool (gSaveChanges);
|
||||
FreePool (gFunctionOneString);
|
||||
FreePool (gFunctionTwoString);
|
||||
FreePool (gFunctionNineString);
|
||||
FreePool (gFunctionTenString);
|
||||
FreePool (gEnterString);
|
||||
FreePool (gEnterCommitString);
|
||||
FreePool (gEscapeString);
|
||||
FreePool (gMoveHighlight);
|
||||
FreePool (gMakeSelection);
|
||||
FreePool (gDecNumericInput);
|
||||
FreePool (gHexNumericInput);
|
||||
FreePool (gToggleCheckBox);
|
||||
FreePool (gPromptForData);
|
||||
FreePool (gPromptForPassword);
|
||||
FreePool (gPromptForNewPassword);
|
||||
FreePool (gConfirmPassword);
|
||||
FreePool (gPassowordInvalid);
|
||||
FreePool (gConfirmError);
|
||||
FreePool (gPressEnter);
|
||||
FreePool (gEmptyString);
|
||||
FreePool (gAreYouSure);
|
||||
FreePool (gYesResponse);
|
||||
FreePool (gNoResponse);
|
||||
FreePool (gMiniString);
|
||||
FreePool (gPlusString);
|
||||
FreePool (gMinusString);
|
||||
FreePool (gAdjustNumber);
|
||||
FreePool (gSaveChanges);
|
||||
return ;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user