From 6e5676b3800b4bf939df1a058f231ab38761f7ce Mon Sep 17 00:00:00 2001 From: shenglei Date: Wed, 8 Aug 2018 16:16:30 +0800 Subject: [PATCH] MdeModulePkg EmmcBlockIoPei: Remove a redundant function The function EmmcPeimUnlinkMemBlock that is never called has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 v2: Remove the comment that mentioned 'EmmcPeimUnlinkMemBlock' within function EmmcPeimFreeMemPool(). Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Hao Wu Reviewed-by: Star Zeng --- .../Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c | 26 ------------------- 1 file changed, 26 deletions(-) diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c index a6f188f385..a55a34a3dc 100644 --- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c +++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c @@ -219,31 +219,7 @@ EmmcPeimIsMemBlockEmpty ( return TRUE; } -/** - Unlink the memory block from the pool's list. - @param Head The block list head of the memory's pool. - @param BlockToUnlink The memory block to unlink. - -**/ -VOID -EmmcPeimUnlinkMemBlock ( - IN EMMC_PEIM_MEM_BLOCK *Head, - IN EMMC_PEIM_MEM_BLOCK *BlockToUnlink - ) -{ - EMMC_PEIM_MEM_BLOCK *Block; - - ASSERT ((Head != NULL) && (BlockToUnlink != NULL)); - - for (Block = Head; Block != NULL; Block = Block->Next) { - if (Block->Next == BlockToUnlink) { - Block->Next = BlockToUnlink->Next; - BlockToUnlink->Next = NULL; - break; - } - } -} /** Initialize the memory management pool for the host controller. @@ -305,8 +281,6 @@ EmmcPeimFreeMemPool ( // // Unlink all the memory blocks from the pool, then free them. - // EmmcPeimUnlinkMemBlock can't be used to unlink and free the - // first block. // for (Block = Pool->Head->Next; Block != NULL; Block = Pool->Head->Next) { EmmcPeimFreeMemBlock (Pool, Block);