From 7046a2739ae74f5d5c86ea18dc4bcc855e4916c6 Mon Sep 17 00:00:00 2001 From: Hao Wu Date: Tue, 29 Aug 2017 19:33:09 +0800 Subject: [PATCH] IntelSiliconPkg/PlatformVTdSample: Avoid using constant result 'if' In this sample driver, if (0) {...} else {...} statements were used to illustrate two different using scenarios. This comment refines the coding style by substituting the 'if (0)' statement with comments to select sample codes for different cases. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu Reviewed-by: Jiewen Yao --- .../PlatformVTdSampleDxe.c | 42 ++++++++++++------- 1 file changed, 26 insertions(+), 16 deletions(-) diff --git a/IntelSiliconPkg/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c b/IntelSiliconPkg/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c index 07499c7da8..3587fa3c83 100644 --- a/IntelSiliconPkg/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c +++ b/IntelSiliconPkg/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c @@ -339,23 +339,33 @@ PlatformVTdGetExceptionDeviceList ( return EFI_INVALID_PARAMETER; } - if (0) { - *DeviceInfo = AllocateZeroPool (sizeof(mExceptionDeviceScopeList)); - if (*DeviceInfo == NULL) { - return EFI_OUT_OF_RESOURCES; - } - CopyMem (*DeviceInfo, mExceptionDeviceScopeList, sizeof(mExceptionDeviceScopeList)); - - *DeviceInfoCount = ARRAY_SIZE(mExceptionDeviceScopeList); - } else { - *DeviceInfo = AllocateZeroPool (sizeof(mExceptionPciDeviceIdList)); - if (*DeviceInfo == NULL) { - return EFI_OUT_OF_RESOURCES; - } - CopyMem (*DeviceInfo, mExceptionPciDeviceIdList, sizeof(mExceptionPciDeviceIdList)); - - *DeviceInfoCount = ARRAY_SIZE(mExceptionPciDeviceIdList); + // + // Sample codes for device scope based exception list. + // Uncomment to take affect and comment the sample codes for PCI vendor id + // based exception list. + // + /* + *DeviceInfo = AllocateZeroPool (sizeof(mExceptionDeviceScopeList)); + if (*DeviceInfo == NULL) { + return EFI_OUT_OF_RESOURCES; } + CopyMem (*DeviceInfo, mExceptionDeviceScopeList, sizeof(mExceptionDeviceScopeList)); + + *DeviceInfoCount = ARRAY_SIZE(mExceptionDeviceScopeList); + */ + + // + // Sample codes for PCI vendor id based exception list. + // Uncomment to take affect and comment the sample codes for device scope + // based exception list. + // + *DeviceInfo = AllocateZeroPool (sizeof(mExceptionPciDeviceIdList)); + if (*DeviceInfo == NULL) { + return EFI_OUT_OF_RESOURCES; + } + CopyMem (*DeviceInfo, mExceptionPciDeviceIdList, sizeof(mExceptionPciDeviceIdList)); + + *DeviceInfoCount = ARRAY_SIZE(mExceptionPciDeviceIdList); return EFI_SUCCESS; }