sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MdePkg/Include: Add volatile to SynchronizationLib parameters

Browse Source 
The SpinLock functions in the SynchronicationLib use volatile
parameters to keep compiler from optimizing these functions
too much.  The volatile keyword is missing from the Interlocked*()
functions in this same library class.  Update the library class
to consistently use volatile on all functions in this class.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
This commit is contained in:
Michael Kinney
2016-11-17 10:57:53 -08:00
parent 8b66342c6b
commit 7375f3f11a
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
MdePkg/Include/Library/SynchronizationLib.h
View File

@ -1,7 +1,7 @@
/** @file /** @file
Provides synchronization functions. Provides synchronization functions.
Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.<BR> Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -157,7 +157,7 @@ ReleaseSpinLock (
UINT32 UINT32
EFIAPI EFIAPI
InterlockedIncrement ( InterlockedIncrement (
IN UINT32 *Value IN volatile UINT32 *Value
); );
@ -179,7 +179,7 @@ InterlockedIncrement (
UINT32 UINT32
EFIAPI EFIAPI
InterlockedDecrement ( InterlockedDecrement (
IN UINT32 *Value IN volatile UINT32 *Value
); );
@ -204,7 +204,7 @@ InterlockedDecrement (
UINT16 UINT16
EFIAPI EFIAPI
InterlockedCompareExchange16 ( InterlockedCompareExchange16 (
IN OUT UINT16 *Value, IN OUT volatile UINT16 *Value,
IN UINT16 CompareValue, IN UINT16 CompareValue,
IN UINT16 ExchangeValue IN UINT16 ExchangeValue
); );
@ -231,7 +231,7 @@ InterlockedCompareExchange16 (
UINT32 UINT32
EFIAPI EFIAPI
InterlockedCompareExchange32 ( InterlockedCompareExchange32 (
IN OUT UINT32 *Value, IN OUT volatile UINT32 *Value,
IN UINT32 CompareValue, IN UINT32 CompareValue,
IN UINT32 ExchangeValue IN UINT32 ExchangeValue
); );
@ -258,7 +258,7 @@ InterlockedCompareExchange32 (
UINT64 UINT64
EFIAPI EFIAPI
InterlockedCompareExchange64 ( InterlockedCompareExchange64 (
IN OUT UINT64 *Value, IN OUT volatile UINT64 *Value,
IN UINT64 CompareValue, IN UINT64 CompareValue,
IN UINT64 ExchangeValue IN UINT64 ExchangeValue
); );
@ -285,7 +285,7 @@ InterlockedCompareExchange64 (
VOID * VOID *
EFIAPI EFIAPI
InterlockedCompareExchangePointer ( InterlockedCompareExchangePointer (
IN OUT VOID **Value, IN OUT VOID * volatile *Value,
IN VOID *CompareValue, IN VOID *CompareValue,
IN VOID *ExchangeValue IN VOID *ExchangeValue
); );