sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

OvmfPkg: Change OPTIONAL keyword usage style

Browse Source 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3760

Update all use of ', OPTIONAL' to ' OPTIONAL,' for function params.

Cc: Andrew Fish <afish@apple.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Andrew Fish <afish@apple.com>
This commit is contained in:
Michael D Kinney
2021-12-02 18:00:53 -08:00
committed by mergify[bot]
parent 8874fa199d
commit 79d49e162e
25 changed files with 86 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c
View File

@@ -2249,7 +2249,7 @@ CopyVideoBuffer (
EFI_STATUS
BiosVideoVbeBltWorker (
IN BIOS_VIDEO_DEV *BiosVideoPrivate,
IN EFI_GRAPHICS_OUTPUT_BLT_PIXEL *BltBuffer, OPTIONAL
IN EFI_GRAPHICS_OUTPUT_BLT_PIXEL *BltBuffer OPTIONAL,
IN EFI_GRAPHICS_OUTPUT_BLT_OPERATION BltOperation,
IN UINTN SourceX,
IN UINTN SourceY,
@@ -2518,7 +2518,7 @@ EFI_STATUS
EFIAPI
BiosVideoGraphicsOutputVbeBlt (
IN EFI_GRAPHICS_OUTPUT_PROTOCOL *This,
IN EFI_GRAPHICS_OUTPUT_BLT_PIXEL *BltBuffer, OPTIONAL
IN EFI_GRAPHICS_OUTPUT_BLT_PIXEL *BltBuffer OPTIONAL,
IN EFI_GRAPHICS_OUTPUT_BLT_OPERATION BltOperation,
IN UINTN SourceX,
IN UINTN SourceY,
@@ -2740,7 +2740,7 @@ EFI_STATUS
EFIAPI
BiosVideoGraphicsOutputVgaBlt (
IN EFI_GRAPHICS_OUTPUT_PROTOCOL *This,
IN EFI_GRAPHICS_OUTPUT_BLT_PIXEL *BltBuffer, OPTIONAL
IN EFI_GRAPHICS_OUTPUT_BLT_PIXEL *BltBuffer OPTIONAL,
IN EFI_GRAPHICS_OUTPUT_BLT_OPERATION BltOperation,
IN UINTN SourceX,
IN UINTN SourceY,
@@ -3286,4 +3286,3 @@ BiosVideoEntryPoint(
NULL
);
}

4
OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h
View File

@@ -334,7 +334,7 @@ EFI_STATUS
EFIAPI
BiosVideoGraphicsOutputVbeBlt (
IN EFI_GRAPHICS_OUTPUT_PROTOCOL *This,
IN EFI_GRAPHICS_OUTPUT_BLT_PIXEL *BltBuffer, OPTIONAL
IN EFI_GRAPHICS_OUTPUT_BLT_PIXEL *BltBuffer OPTIONAL,
IN EFI_GRAPHICS_OUTPUT_BLT_OPERATION BltOperation,
IN UINTN SourceX,
IN UINTN SourceY,
@@ -377,7 +377,7 @@ EFI_STATUS
EFIAPI
BiosVideoGraphicsOutputVgaBlt (
IN EFI_GRAPHICS_OUTPUT_PROTOCOL *This,
IN EFI_GRAPHICS_OUTPUT_BLT_PIXEL *BltBuffer, OPTIONAL
IN EFI_GRAPHICS_OUTPUT_BLT_PIXEL *BltBuffer OPTIONAL,
IN EFI_GRAPHICS_OUTPUT_BLT_OPERATION BltOperation,
IN UINTN SourceX,
IN UINTN SourceY,

13
OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c
View File

@@ -616,9 +616,9 @@ PlatformHooks (
IN EFI_LEGACY_BIOS_PLATFORM_PROTOCOL *This,
IN EFI_GET_PLATFORM_HOOK_MODE Mode,
IN UINT16 Type,
OUT EFI_HANDLE DeviceHandle, OPTIONAL
IN OUT UINTN *Shadowaddress, OPTIONAL
IN EFI_COMPATIBILITY16_TABLE *Compatibility16Table, OPTIONAL
OUT EFI_HANDLE DeviceHandle OPTIONAL,
IN OUT UINTN *Shadowaddress OPTIONAL,
IN EFI_COMPATIBILITY16_TABLE *Compatibility16Table OPTIONAL,
OUT VOID **AdditionalData OPTIONAL
)
{
@@ -674,9 +674,9 @@ GetRoutingTable (
IN EFI_LEGACY_BIOS_PLATFORM_PROTOCOL *This,
OUT VOID **RoutingTable,
OUT UINTN *RoutingTableEntries,
OUT VOID **LocalPirqTable, OPTIONAL
OUT UINTN *PirqTableSize, OPTIONAL
OUT VOID **LocalIrqPriorityTable, OPTIONAL
OUT VOID **LocalPirqTable OPTIONAL,
OUT UINTN *PirqTableSize OPTIONAL,
OUT VOID **LocalIrqPriorityTable OPTIONAL,
OUT UINTN *IrqPriorityTableEntries OPTIONAL
)
{
@@ -1057,4 +1057,3 @@ LegacyBiosPlatformInstall (
);
return Status;
}

10
OvmfPkg/Csm/Include/Protocol/LegacyBios.h
View File

@@ -1200,8 +1200,8 @@ EFI_STATUS
(EFIAPI *EFI_LEGACY_BIOS_CHECK_ROM)(
IN EFI_LEGACY_BIOS_PROTOCOL *This,
IN EFI_HANDLE PciHandle,
OUT VOID **RomImage, OPTIONAL
OUT UINTN *RomSize, OPTIONAL
OUT VOID **RomImage OPTIONAL,
OUT UINTN *RomSize OPTIONAL,
OUT UINTN *Flags
);
@@ -1239,9 +1239,9 @@ EFI_STATUS
IN EFI_HANDLE PciHandle,
IN VOID **RomImage,
OUT UINTN *Flags,
OUT UINT8 *DiskStart, OPTIONAL
OUT UINT8 *DiskEnd, OPTIONAL
OUT VOID **RomShadowAddress, OPTIONAL
OUT UINT8 *DiskStart OPTIONAL,
OUT UINT8 *DiskEnd OPTIONAL,
OUT VOID **RomShadowAddress OPTIONAL,
OUT UINT32 *ShadowedRomSize OPTIONAL
);

12
OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h
View File

@@ -629,9 +629,9 @@ EFI_STATUS
IN EFI_LEGACY_BIOS_PLATFORM_PROTOCOL *This,
IN EFI_GET_PLATFORM_HOOK_MODE Mode,
IN UINT16 Type,
IN EFI_HANDLE DeviceHandle, OPTIONAL
IN OUT UINTN *ShadowAddress, OPTIONAL
IN EFI_COMPATIBILITY16_TABLE *Compatibility16Table, OPTIONAL
IN EFI_HANDLE DeviceHandle OPTIONAL,
IN OUT UINTN *ShadowAddress OPTIONAL,
IN EFI_COMPATIBILITY16_TABLE *Compatibility16Table OPTIONAL,
OUT VOID **AdditionalData OPTIONAL
);
@@ -660,9 +660,9 @@ EFI_STATUS
IN EFI_LEGACY_BIOS_PLATFORM_PROTOCOL *This,
OUT VOID **RoutingTable,
OUT UINTN *RoutingTableEntries,
OUT VOID **LocalPirqTable, OPTIONAL
OUT UINTN *PirqTableSize, OPTIONAL
OUT VOID **LocalIrqPriorityTable, OPTIONAL
OUT VOID **LocalPirqTable OPTIONAL,
OUT UINTN *PirqTableSize OPTIONAL,
OUT VOID **LocalIrqPriorityTable OPTIONAL,
OUT UINTN *IrqPriorityTableEntries OPTIONAL
);

20
OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h
View File

@@ -750,8 +750,8 @@ EFIAPI
LegacyBiosCheckPciRom (
IN EFI_LEGACY_BIOS_PROTOCOL *This,
IN EFI_HANDLE PciHandle,
OUT VOID **RomImage, OPTIONAL
OUT UINTN *RomSize, OPTIONAL
OUT VOID **RomImage OPTIONAL,
OUT UINTN *RomSize OPTIONAL,
OUT UINTN *Flags
);
@@ -838,9 +838,9 @@ LegacyBiosInstallPciRom (
IN EFI_HANDLE PciHandle,
IN VOID **RomImage,
OUT UINTN *Flags,
OUT UINT8 *DiskStart, OPTIONAL
OUT UINT8 *DiskEnd, OPTIONAL
OUT VOID **RomShadowAddress, OPTIONAL
OUT UINT8 *DiskStart OPTIONAL,
OUT UINT8 *DiskEnd OPTIONAL,
OUT VOID **RomShadowAddress OPTIONAL,
OUT UINT32 *RomShadowedSize OPTIONAL
);
@@ -1388,11 +1388,11 @@ EFI_STATUS
LegacyBiosCheckPciRomEx (
IN EFI_LEGACY_BIOS_PROTOCOL *This,
IN EFI_HANDLE PciHandle,
OUT VOID **RomImage, OPTIONAL
OUT UINTN *RomSize, OPTIONAL
OUT UINTN *RuntimeImageLength, OPTIONAL
OUT UINTN *Flags, OPTIONAL
OUT UINT8 *OpromRevision, OPTIONAL
OUT VOID **RomImage OPTIONAL,
OUT UINTN *RomSize OPTIONAL,
OUT UINTN *RuntimeImageLength OPTIONAL,
OUT UINTN *Flags OPTIONAL,
OUT UINT8 *OpromRevision OPTIONAL,
OUT VOID **ConfigUtilityCodeHeader OPTIONAL
);

35
OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c
View File

@@ -52,9 +52,9 @@ EDKII_IOMMU_PROTOCOL *mIoMmu;
EFI_STATUS
GetShadowedRomParameters (
IN EFI_HANDLE PciHandle,
OUT UINT8 *DiskStart, OPTIONAL
OUT UINT8 *DiskEnd, OPTIONAL
OUT VOID **RomShadowAddress, OPTIONAL
OUT UINT8 *DiskStart OPTIONAL,
OUT UINT8 *DiskEnd OPTIONAL,
OUT VOID **RomShadowAddress OPTIONAL,
OUT UINTN *ShadowedSize OPTIONAL
)
{
@@ -276,8 +276,8 @@ GetPciLegacyRom (
IN UINT16 DeviceId,
IN OUT VOID **Rom,
IN OUT UINTN *ImageSize,
OUT UINTN *MaxRuntimeImageLength, OPTIONAL
OUT UINT8 *OpRomRevision, OPTIONAL
OUT UINTN *MaxRuntimeImageLength OPTIONAL,
OUT UINT8 *OpRomRevision OPTIONAL,
OUT VOID **ConfigUtilityCodeHeader OPTIONAL
)
{
@@ -1814,8 +1814,8 @@ EFIAPI
LegacyBiosCheckPciRom (
IN EFI_LEGACY_BIOS_PROTOCOL *This,
IN EFI_HANDLE PciHandle,
OUT VOID **RomImage, OPTIONAL
OUT UINTN *RomSize, OPTIONAL
OUT VOID **RomImage OPTIONAL,
OUT UINTN *RomSize OPTIONAL,
OUT UINTN *Flags
)
{
@@ -1856,11 +1856,11 @@ EFI_STATUS
LegacyBiosCheckPciRomEx (
IN EFI_LEGACY_BIOS_PROTOCOL *This,
IN EFI_HANDLE PciHandle,
OUT VOID **RomImage, OPTIONAL
OUT UINTN *RomSize, OPTIONAL
OUT UINTN *RuntimeImageLength, OPTIONAL
OUT UINTN *Flags, OPTIONAL
OUT UINT8 *OpromRevision, OPTIONAL
OUT VOID **RomImage OPTIONAL,
OUT UINTN *RomSize OPTIONAL,
OUT UINTN *RuntimeImageLength OPTIONAL,
OUT UINTN *Flags OPTIONAL,
OUT UINT8 *OpromRevision OPTIONAL,
OUT VOID **ConfigUtilityCodeHeader OPTIONAL
)
{
@@ -2256,8 +2256,8 @@ LegacyBiosInstallRom (
IN VOID *RomImage,
IN UINTN ImageSize,
IN OUT UINTN *RuntimeImageLength,
OUT UINT8 *DiskStart, OPTIONAL
OUT UINT8 *DiskEnd, OPTIONAL
OUT UINT8 *DiskStart OPTIONAL,
OUT UINT8 *DiskEnd OPTIONAL,
OUT VOID **RomShadowAddress OPTIONAL
)
{
@@ -2791,9 +2791,9 @@ LegacyBiosInstallPciRom (
IN EFI_HANDLE PciHandle,
IN VOID **RomImage,
OUT UINTN *Flags,
OUT UINT8 *DiskStart, OPTIONAL
OUT UINT8 *DiskEnd, OPTIONAL
OUT VOID **RomShadowAddress, OPTIONAL
OUT UINT8 *DiskStart OPTIONAL,
OUT UINT8 *DiskEnd OPTIONAL,
OUT VOID **RomShadowAddress OPTIONAL,
OUT UINT32 *RomShadowedSize OPTIONAL
)
{
@@ -3080,4 +3080,3 @@ LegacyBiosInstallPciRom (
mVgaInstallationInProgress = FALSE;
return Status;
}