add security check.
update functions comments. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8832 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
@@ -542,6 +542,7 @@ DhcpFillOption (
|
||||
@param[out] OptionPoint The array that contains the DHCP options. Caller
|
||||
should free it.
|
||||
|
||||
@retval EFI_NOT_FOUND Cannot find any option.
|
||||
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory to parse the packet.
|
||||
@retval EFI_INVALID_PARAMETER The options are mal-formated
|
||||
@retval EFI_SUCCESS The options are parsed into OptionPoint
|
||||
@@ -603,6 +604,7 @@ DhcpParseOption (
|
||||
*OptionPoint = NULL;
|
||||
|
||||
if (OptNum == 0) {
|
||||
Status = EFI_NOT_FOUND;
|
||||
goto ON_EXIT;
|
||||
}
|
||||
|
||||
@@ -673,13 +675,12 @@ DhcpValidateOptions (
|
||||
if (EFI_ERROR (Status) || (Count == 0)) {
|
||||
return Status;
|
||||
}
|
||||
|
||||
|
||||
Updated = FALSE;
|
||||
ZeroMem (&Parameter, sizeof (Parameter));
|
||||
|
||||
for (Index = 0; Index < Count; Index++) {
|
||||
Option = &AllOption[Index];
|
||||
ASSERT (Option != NULL);
|
||||
|
||||
//
|
||||
// Find the format of the option then validate it.
|
||||
|
@@ -280,6 +280,7 @@ DhcpValidateOptions (
|
||||
@param[out] OptionPoint The array that contains the DHCP options. Caller
|
||||
should free it.
|
||||
|
||||
@retval EFI_NOT_FOUND Cannot find any option.
|
||||
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory to parse the packet.
|
||||
@retval EFI_INVALID_PARAMETER The options are mal-formated
|
||||
@retval EFI_SUCCESS The options are parsed into OptionPoint
|
||||
|
@@ -88,9 +88,9 @@ PxeNvDataRead (
|
||||
return EFI_DEVICE_ERROR;
|
||||
}
|
||||
|
||||
ASSERT ((Offset + BufferSize) <= sizeof (Db->Data));
|
||||
ASSERT (Offset < sizeof (Db->Data));
|
||||
|
||||
CopyMem (Buffer, Db->Data.Byte + Offset, BufferSize);
|
||||
CopyMem (Buffer, &Db->Data.Byte[Offset], BufferSize);
|
||||
|
||||
return EFI_SUCCESS;
|
||||
}
|
||||
|
@@ -1715,10 +1715,10 @@ PxeBcSelectBootMenu (
|
||||
}
|
||||
|
||||
while (MenuSize > 0) {
|
||||
MenuArray[Index] = MenuItem;
|
||||
MenuArray[Index++] = MenuItem;
|
||||
MenuSize = (UINT8) (MenuSize - (MenuItem->DescLen + 3));
|
||||
MenuItem = (PXEBC_BOOT_MENU_ENTRY *) ((UINT8 *) MenuItem + MenuItem->DescLen + 3);
|
||||
if (Index++ > (PXEBC_MAX_MENU_NUM - 1)) {
|
||||
if (Index >= PXEBC_MAX_MENU_NUM) {
|
||||
break;
|
||||
}
|
||||
}
|
||||
@@ -1738,6 +1738,7 @@ PxeBcSelectBootMenu (
|
||||
TopRow = gST->ConOut->Mode->CursorRow - MenuNum;
|
||||
|
||||
do {
|
||||
ASSERT (Select < PXEBC_MAX_MENU_NUM);
|
||||
//
|
||||
// highlight selected row
|
||||
//
|
||||
|
Reference in New Issue
Block a user