sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

NetworkPkg: Replace ASSERT with error handling in Http boot and IScsi

Browse Source 
v2:
*Fix some memory leak issue.

This patch is used to replace ASSERT with error handling in Http boot
Driver and IScsi driver.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zhang@intel.com>
Reviewed-By: Wu Jiaxin <jiaxin.wu@intel.com>
This commit is contained in:
Zhang Lubo
2016-06-21 14:40:28 +08:00
committed by Jiaxin Wu
parent 3460c75dfe
commit 7c275b3cde
6 changed files with 30 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
NetworkPkg/IScsiDxe/IScsiMisc.c
View File

@@ -1006,6 +1006,7 @@ IScsiDhcpIsConfigured (
@retval EFI_SUCCESS The configuration data is retrieved.
@retval EFI_NOT_FOUND This iSCSI driver is not configured yet.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory.
**/
EFI_STATUS
@@ -1292,7 +1293,9 @@ IScsiGetConfigData (
mPrivate->PortString,
NULL
);
ASSERT (AttemptConfigData->AttemptTitleHelpToken != 0);
if (AttemptConfigData->AttemptTitleHelpToken == 0) {
return EFI_OUT_OF_RESOURCES;
}
//
// Record the attempt in global link list.