MdeModulePkg/Ip4Dxe: Add wrong/invalid subnet check
v2: * Separate out the return status fix. * Replace IP4_MASK_MAX with IP4_MASK_NUM. * Remove the ON_EXIT label. This patch is used to add the wrong/invalid subnet check. Cc: Santhapur Naveen <naveens@amiindia.co.in> Cc: Laszlo Ersek <lersek@redhat.com> Cc: Ye Ting <ting.ye@intel.com> Cc: Fu Siyuan <siyuan.fu@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com> Reviewed-by: Ye Ting <ting.ye@intel.com> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
This commit is contained in:
@@ -1255,6 +1255,13 @@ Ip4Config2SetMaunualAddress (
|
||||
|
||||
NewAddress = *((EFI_IP4_CONFIG2_MANUAL_ADDRESS *) Data);
|
||||
|
||||
StationAddress = EFI_NTOHL (NewAddress.Address);
|
||||
SubnetMask = EFI_NTOHL (NewAddress.SubnetMask);
|
||||
|
||||
if (NetGetMaskLength (SubnetMask) == IP4_MASK_NUM) {
|
||||
return EFI_INVALID_PARAMETER;
|
||||
}
|
||||
|
||||
//
|
||||
// Store the new data, and init the DataItem status to EFI_NOT_READY because
|
||||
// we may have an asynchronous configuration process.
|
||||
@@ -1273,9 +1280,6 @@ Ip4Config2SetMaunualAddress (
|
||||
DataItem->DataSize = DataSize;
|
||||
DataItem->Status = EFI_NOT_READY;
|
||||
|
||||
StationAddress = EFI_NTOHL (NewAddress.Address);
|
||||
SubnetMask = EFI_NTOHL (NewAddress.SubnetMask);
|
||||
|
||||
IpSb->Reconfig = TRUE;
|
||||
Status = Ip4Config2SetDefaultAddr (IpSb, StationAddress, SubnetMask);
|
||||
if (EFI_ERROR (Status)) {
|
||||
|
Reference in New Issue
Block a user