sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MdeModulePkg: Remove event from protocol database only if registered

Browse Source 
In a CloseEvent, an UnregisterProtocolNotify is done unconditionally.
There is a penalty associated with searching the protocol database on
every CloseEvent and impacts performance, especially during Network IO.
Unregister needs to be done only if the Event is for a RegisterProtocolNotify.

So extend the ExFlag in IEVENT to a UINT8 and define new flags that can
be set to indicate if the Event is part of a group, or registered on a
protocol notify. Then in CloseEvent, call UnregisterProtocolNotify only
if the register protocol notify flag is set.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@hpe.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18517 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
Samer El-Haj-Mahmoud
2015-09-21 01:53:34 +00:00
committed by erictian
parent e630f8595a
commit 82f3edf26a
3 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
MdeModulePkg/Core/Dxe/Event/Event.c
View File

@ -2,6 +2,7 @@
UEFI Event support functions implemented in this file. UEFI Event support functions implemented in this file.
Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR> Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -477,7 +478,7 @@ CoreCreateEventInternal (
IEvent->NotifyContext = (VOID *)NotifyContext; IEvent->NotifyContext = (VOID *)NotifyContext;
if (EventGroup != NULL) { if (EventGroup != NULL) {
CopyGuid (&IEvent->EventGroup, EventGroup); CopyGuid (&IEvent->EventGroup, EventGroup);
IEvent->ExFlag = TRUE; IEvent->ExFlag |= EVT_EXFLAG_EVENT_GROUP;
} }
*Event = IEvent; *Event = IEvent;
@ -554,7 +555,7 @@ CoreSignalEvent (
// If signalling type is a notify function, queue it // If signalling type is a notify function, queue it
// //
if ((Event->Type & EVT_NOTIFY_SIGNAL) != 0) { if ((Event->Type & EVT_NOTIFY_SIGNAL) != 0) {
if (Event->ExFlag) { if ((Event->ExFlag & EVT_EXFLAG_EVENT_GROUP) != 0) {
// //
// The CreateEventEx() style requires all members of the Event Group // The CreateEventEx() style requires all members of the Event Group
// to be signaled. // to be signaled.
@ -764,7 +765,9 @@ CoreCloseEvent (
// //
// If the event is registered on a protocol notify, then remove it from the protocol database // If the event is registered on a protocol notify, then remove it from the protocol database
// //
if ((Event->ExFlag & EVT_EXFLAG_EVENT_PROTOCOL_NOTIFICATION) != 0) {
CoreUnregisterProtocolNotify (Event); CoreUnregisterProtocolNotify (Event);
}
Status = CoreFreePool (Event); Status = CoreFreePool (Event);
ASSERT_EFI_ERROR (Status); ASSERT_EFI_ERROR (Status);

11
MdeModulePkg/Core/Dxe/Event/Event.h
View File

@ -2,6 +2,7 @@
UEFI Event support functions and structure. UEFI Event support functions and structure.
Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR> Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -19,6 +20,14 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
#define VALID_TPL(a) ((a) <= TPL_HIGH_LEVEL) #define VALID_TPL(a) ((a) <= TPL_HIGH_LEVEL)
extern UINTN gEventPending; extern UINTN gEventPending;
///
/// Set if Event is part of an event group
///
#define EVT_EXFLAG_EVENT_GROUP 0x01
///
/// Set if Event is registered on a protocol notify
///
#define EVT_EXFLAG_EVENT_PROTOCOL_NOTIFICATION 0x02
// //
// EFI_EVENT // EFI_EVENT
@ -50,7 +59,7 @@ typedef struct {
VOID *NotifyContext; VOID *NotifyContext;
EFI_GUID EventGroup; EFI_GUID EventGroup;
LIST_ENTRY NotifyLink; LIST_ENTRY NotifyLink;
BOOLEAN ExFlag; UINT8 ExFlag;
/// ///
/// A list of all runtime events /// A list of all runtime events
/// ///

5
MdeModulePkg/Core/Dxe/Hand/Notify.c
View File

@ -2,6 +2,7 @@
Support functions for UEFI protocol notification infrastructure. Support functions for UEFI protocol notification infrastructure.
Copyright (c) 2006 - 2008, Intel Corporation. All rights reserved.<BR> Copyright (c) 2006 - 2008, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -14,7 +15,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
#include "DxeMain.h" #include "DxeMain.h"
#include "Handle.h" #include "Handle.h"
#include "Event.h"
/** /**
Signal event for every protocol in protocol entry. Signal event for every protocol in protocol entry.
@ -135,7 +136,7 @@ CoreRegisterProtocolNotify (
// //
ProtNotify = AllocatePool (sizeof(PROTOCOL_NOTIFY)); ProtNotify = AllocatePool (sizeof(PROTOCOL_NOTIFY));
if (ProtNotify != NULL) { if (ProtNotify != NULL) {
((IEVENT *)Event)->ExFlag |= EVT_EXFLAG_EVENT_PROTOCOL_NOTIFICATION;
ProtNotify->Signature = PROTOCOL_NOTIFY_SIGNATURE; ProtNotify->Signature = PROTOCOL_NOTIFY_SIGNATURE;
ProtNotify->Protocol = ProtEntry; ProtNotify->Protocol = ProtEntry;
ProtNotify->Event = Event; ProtNotify->Event = Event;