sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BaseTools/UPT: Add a checkpoint for missing '"'

Browse Source 
Add a checkpoint for UNI file which is missing '"' at the end of a line.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hess Chen <hesheng.chen@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
This commit is contained in:
Hess Chen
2017-03-07 14:01:34 +08:00
committed by Yonghong Zhu
parent b7f63a5a53
commit 85ea493fb7
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
BaseTools/Source/Python/UPT/Library/UniClassObject.py
View File

@ -1,7 +1,7 @@
## @file ## @file
# Collect all defined strings in multiple uni files. # Collect all defined strings in multiple uni files.
# #
# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR> # Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.<BR>
# #
# This program and the accompanying materials are licensed and made available # This program and the accompanying materials are licensed and made available
# under the terms and conditions of the BSD License which accompanies this # under the terms and conditions of the BSD License which accompanies this
@ -558,7 +558,16 @@ class UniFileClassObject(object):
Message="Cannot find include file", Message="Cannot find include file",
ExtraData=str(IncList[0])) ExtraData=str(IncList[0]))
continue continue
#
# Check if single line has correct '"'
#
if Line.startswith(u'#string') and Line.find(u'#language') > -1 and Line.find('"') > Line.find(u'#language'):
if not Line.endswith('"'):
EdkLogger.Error("Unicode File Parser", ToolError.FORMAT_INVALID,
ExtraData='''The line %s misses '"' at the end of it in file %s'''
% (LineCount, File.Path))
# #
# Between Name entry and Language entry can not contain line feed # Between Name entry and Language entry can not contain line feed
# #