sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "UefiCpuPkg: Check invalid RegisterCpuFeature parameter"

Browse Source 
This reverts commit 5c59537c10.

Current code already has function IsCpuFeatureSupported to do
the feature validation, not need this check logic anymore.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bell Song <binx.song@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
This commit is contained in:
Eric Dong
2017-12-21 19:46:51 +08:00
parent 726c501c2c
commit 8766d3a3e8
2 changed files with 0 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
View File

@@ -80,34 +80,6 @@ DumpCpuFeature (
}
}
/**
Determines if the CPU feature is valid.
@param[in] Feature Pointer to CPU feature
@retval TRUE The CPU feature is valid.
@retval FALSE The CPU feature is invalid.
**/
BOOLEAN
RegisterCpuFeatureLibIsFeatureValid (
IN UINT32 Feature
)
{
UINT32 Data;
Data = Feature;
Data &= ~(CPU_FEATURE_BEFORE | CPU_FEATURE_AFTER | CPU_FEATURE_BEFORE_ALL | CPU_FEATURE_AFTER_ALL);
//
// Currently, CPU_FEATURE_PROC_TRACE is the MAX feature we support.
// If you define a feature bigger than it, please replace it at below.
//
if (Data > CPU_FEATURE_PROC_TRACE) {
DEBUG ((DEBUG_ERROR, "Invalid CPU feature: 0x%x ", Feature));
return FALSE;
}
return TRUE;
}
/**
Determines if the feature bit mask is in dependent CPU feature bit mask buffer.
@@ -472,7 +444,6 @@ RegisterCpuFeature (
VA_START (Marker, InitializeFunc);
Feature = VA_ARG (Marker, UINT32);
ASSERT (RegisterCpuFeatureLibIsFeatureValid(Feature));
while (Feature != CPU_FEATURE_END) {
ASSERT ((Feature & (CPU_FEATURE_BEFORE | CPU_FEATURE_AFTER))
!= (CPU_FEATURE_BEFORE | CPU_FEATURE_AFTER));