add security check.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8819 6f19259b-4bc3-4df7-8a09-765794883524

MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c

@@ -37,8 +37,6 @@ UINT8 mInterestedDhcp4Tags[PXEBC_DHCP4_TAG_INDEX_MAX] = {
   @param  Seed    Pointer to the message instance of the DHCP4 packet.
   @param  Udp4    Pointer to the EFI_UDP4_PROTOCOL instance.
 
-  @return none.
-
 **/
 VOID
 PxeBcInitSeedPacket (
@@ -73,8 +71,6 @@ PxeBcInitSeedPacket (
   @param  Dst   Pointer to the EFI_DHCP4_PROTOCOL instance.
   @param  Src   Pointer to the EFI_DHCP4_PROTOCOL instance.
 
-  @return None.
-
 **/
 VOID
 PxeBcCopyEfiDhcp4Packet (
@@ -96,8 +92,6 @@ PxeBcCopyEfiDhcp4Packet (
   @param  OfferIndex    Index of cached packets as complements of pxe mode data,
                         the index is maximum offer number.
 
-  @return None.
-
 **/
 VOID
 PxeBcCopyProxyOffer (
@@ -109,6 +103,7 @@ PxeBcCopyProxyOffer (
   EFI_DHCP4_PACKET        *Offer;
 
   ASSERT (OfferIndex < Private->NumOffers);
+  ASSERT (OfferIndex < PXEBC_MAX_OFFER_NUM);
 
   Mode  = Private->PxeBc.Mode;
   Offer = &Private->Dhcp4Offers[OfferIndex].Packet.Offer;
@@ -532,8 +527,6 @@ PxeBcCheckSelectedOffer (
   @param  Private    Pointer to PxeBc private data.
   @param  RcvdOffer  Pointer to the received Dhcp proxy offer packet.
 
-  @return None.
-
 **/
 VOID
 PxeBcCacheDhcpOffer (
@@ -624,8 +617,6 @@ PxeBcCacheDhcpOffer (
   
   @param  Private   Pointer to PxeBc private data.
 
-  @return None
-
 **/
 VOID
 PxeBcSelectOffer (
@@ -1465,8 +1456,6 @@ PxeBcParseVendorOptions (
   @param  Str     Pointer to a string (boot item string).
   @param  Len     The length of string.
 
-  @return None.
-
 **/
 VOID
 PxeBcDisplayBootItem (

MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.h

@@ -305,8 +305,6 @@ typedef struct {
   @param  Seed    Pointer to the message instance of the DHCP4 packet.
   @param  Udp4    Pointer to the EFI_UDP4_PROTOCOL instance.
 
-  @return none.
-
 **/
 VOID
 PxeBcInitSeedPacket (
@@ -447,8 +445,6 @@ PxeBcBuildDhcpOptions (
   @param  Layer      the layer of the boot options 
   @param  OptLen     length of opotion
 
-  @return None.
-
 **/
 VOID
 PxeBcCreateBootOptions (

MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c

@@ -84,8 +84,6 @@ UpdateArpCache (
 
   @param  Event              Pointer to EFI_PXE_BC_PROTOCOL
   @param  Context            Context of the timer event
-  
-  @return None.
 
 **/
 VOID
@@ -139,8 +137,6 @@ FindInArpCache (
 
   @param  Context               The PXEBC private data.
 
-  @return None.
-
 **/
 VOID
 EFIAPI
@@ -233,8 +229,6 @@ Resume:
   @param  Event                 The event signaled.
   @param  Context               The context passed in by the event notifier.
 
-  @return None.
-
 **/
 VOID
 EFIAPI

MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcSupport.c

@@ -142,8 +142,6 @@ GetSmbiosSystemGuidAndSerialNumber (
   @param  Event     The event signaled.
   @param  Context   The context.
 
-  @return None
-
 **/
 VOID
 EFIAPI

MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcSupport.h

@@ -38,8 +38,6 @@ GetSmbiosSystemGuidAndSerialNumber (
   @param  Event     The event signaled.
   @param  Context   The context.
 
-  @return None
-
 **/
 VOID
 EFIAPI