UefiCpuPkg: Fix nasm warning "signed byte value exceeds"
Currently, "push byte %[Vector]" causes nasm warning when Vector is larger than 0x7F. This is because push accepts a signed value, and byte means signed int8. Maximum signed int8 is 0x7F. When Vector is larger the 0x7F, for example, when Vector is 255, byte 255 turns to -1, and causes the warning "signed byte value exceeds". To avoid such warning, use dword instead of byte, this will increase 3 bytes for each IdtVector. For IA32, the size of IdtVector will increase from 10 bytes to 13 bytes. For X64, the size of IdtVector will increase from 15 bytes to 18 bytes. Cc: Eric Dong <eric.dong@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Rahul Kumar <rahul1.kumar@intel.com> Cc: Debkumar De <debkumar.de@intel.com> Cc: Harry Han <harry.han@intel.com> Cc: Catharine West <catharine.west@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
This commit is contained in:
committed by
mergify[bot]
parent
fca5de51e1
commit
8a5782d704
@ -34,7 +34,7 @@ ALIGN 8
|
||||
AsmIdtVectorBegin:
|
||||
%assign Vector 0
|
||||
%rep 256
|
||||
push byte %[Vector];
|
||||
push strict dword %[Vector];
|
||||
push eax
|
||||
mov eax, ASM_PFX(CommonInterruptEntry)
|
||||
jmp eax
|
||||
@ -43,9 +43,8 @@ AsmIdtVectorBegin:
|
||||
AsmIdtVectorEnd:
|
||||
|
||||
HookAfterStubBegin:
|
||||
db 0x6a ; push
|
||||
push strict dword 0 ; 0 will be fixed
|
||||
VectorNum:
|
||||
db 0 ; 0 will be fixed
|
||||
push eax
|
||||
mov eax, HookAfterStubHeaderEnd
|
||||
jmp eax
|
||||
@ -453,5 +452,5 @@ global ASM_PFX(AsmVectorNumFixup)
|
||||
ASM_PFX(AsmVectorNumFixup):
|
||||
mov eax, dword [esp + 8]
|
||||
mov ecx, [esp + 4]
|
||||
mov [ecx + (VectorNum - HookAfterStubBegin)], al
|
||||
mov [ecx + (VectorNum - 4 - HookAfterStubBegin)], al
|
||||
ret
|
||||
|
Reference in New Issue
Block a user