sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

SignedCapsulePkg: Remove redundant things in inf,.h and .c files

Browse Source 
Two redundant library classes have been removed.
The redundant function "IsSystemFmp" has been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1067

v2: Remove DxeServicesLib from SystemFirmwareUpdateDxe.inf.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
This commit is contained in:
shenglei 2018-08-10 14:07:18 +08:00 committed by Star Zeng
parent 43fe4c4052
commit 90b3f171a7
4 changed files with 0 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c
View File

@ -343,31 +343,4 @@ InitializePrivateData (
return EFI_SUCCESS; return EFI_SUCCESS;
} }
/**
Return if this FMP is a system FMP or a device FMP, based upon FmpImageInfo.
@param[in] FmpImageInfo A pointer to EFI_FIRMWARE_IMAGE_DESCRIPTOR
@retval TRUE It is a system FMP.
@retval FALSE It is a device FMP.
**/
BOOLEAN
IsSystemFmp (
IN EFI_FIRMWARE_IMAGE_DESCRIPTOR *FmpImageInfo
)
{
GUID *Guid;
UINTN Count;
UINTN Index;
Guid = PcdGetPtr(PcdSystemFmpCapsuleImageTypeIdGuid);
Count = PcdGetSize(PcdSystemFmpCapsuleImageTypeIdGuid) / sizeof(GUID);
for (Index = 0; Index < Count; Index++, Guid++) {
if (CompareGuid(&FmpImageInfo->ImageTypeId, Guid)) {
return TRUE;
}
}
return FALSE;
}

1
SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h
View File

@ -36,7 +36,6 @@
#include <Library/UefiDriverEntryPoint.h> #include <Library/UefiDriverEntryPoint.h>
#include <Library/DevicePathLib.h> #include <Library/DevicePathLib.h>
#include <Library/HobLib.h> #include <Library/HobLib.h>
#include <Library/DxeServicesLib.h>
#include <Library/DxeServicesTableLib.h> #include <Library/DxeServicesTableLib.h>
#include <Library/PlatformFlashAccessLib.h> #include <Library/PlatformFlashAccessLib.h>
#include <Library/EdkiiSystemCapsuleLib.h> #include <Library/EdkiiSystemCapsuleLib.h>

2
SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf
View File

@ -50,9 +50,7 @@
HobLib HobLib
UefiRuntimeServicesTableLib UefiRuntimeServicesTableLib
UefiDriverEntryPoint UefiDriverEntryPoint
DxeServicesLib
DxeServicesTableLib DxeServicesTableLib
PrintLib
EdkiiSystemCapsuleLib EdkiiSystemCapsuleLib
[Pcd] [Pcd]

1
SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf
View File

@ -51,7 +51,6 @@
HobLib HobLib
UefiRuntimeServicesTableLib UefiRuntimeServicesTableLib
UefiDriverEntryPoint UefiDriverEntryPoint
DxeServicesLib
EdkiiSystemCapsuleLib EdkiiSystemCapsuleLib
PlatformFlashAccessLib PlatformFlashAccessLib
IniParsingLib IniParsingLib