sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

1. Fix the potential issue in NetbufGetFragment() when Last is zero in Line 53.

Browse Source 
2. Comments update.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9837 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
tye1
2010-01-27 09:30:35 +00:00
parent 9aa7ba01aa
commit 90f1486c8e
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
MdeModulePkg/Library/DxeNetLib/NetBuffer.c
View File

@ -1,7 +1,7 @@
/** @file /** @file
Network library functions providing net buffer operation support. Network library functions providing net buffer operation support.
Copyright (c) 2005 - 2009, Intel Corporation.<BR> Copyright (c) 2005 - 2010, Intel Corporation.<BR>
All rights reserved. This program and the accompanying materials All rights reserved. This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -508,7 +508,6 @@ NetbufGetFragmentFree (
} }
/** /**
Create a NET_BUF structure which contains Len byte data of Nbuf starting from Create a NET_BUF structure which contains Len byte data of Nbuf starting from
Offset. Offset.
@ -579,9 +578,6 @@ NetbufGetFragment (
FirstSkip = Offset - Cur; FirstSkip = Offset - Cur;
FirstLen = BlockOp[Index].Size - FirstSkip; FirstLen = BlockOp[Index].Size - FirstSkip;
//
//redundant assignment to make compiler happy.
//
Last = 0; Last = 0;
LastLen = 0; LastLen = 0;
@ -605,6 +601,7 @@ NetbufGetFragment (
FirstLen = Len; FirstLen = Len;
} }
ASSERT (Last >= First);
BlockOpNum = Last - First + 1; BlockOpNum = Last - First + 1;
CurBlockOp = 0; CurBlockOp = 0;
@ -640,7 +637,7 @@ NetbufGetFragment (
Child->BlockOp[0].Size = 0; Child->BlockOp[0].Size = 0;
CurBlockOp++; CurBlockOp++;
}else { } else {
Child = NetbufAllocStruct (0, BlockOpNum); Child = NetbufAllocStruct (0, BlockOpNum);
if (Child == NULL) { if (Child == NULL) {
@ -664,7 +661,7 @@ NetbufGetFragment (
CurBlockOp++ CurBlockOp++
); );
for (Index = First + 1; Index <= Last - 1 ; Index++) { for (Index = First + 1; Index < Last; Index++) {
NetbufSetBlockOp ( NetbufSetBlockOp (
Child, Child,
BlockOp[Index].Head, BlockOp[Index].Head,