sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

OvmfPkg/IncompatiblePciDeviceSupportDxe: remove PcdPciDisableBusEnumeration

Browse Source 
At this point, the IncompatiblePciDeviceSupportDxe driver is included in
the following platforms in edk2:

  OvmfPkg/AmdSev/AmdSevX64.dsc
  OvmfPkg/OvmfPkgIa32.dsc
  OvmfPkg/OvmfPkgIa32X64.dsc
  OvmfPkg/OvmfPkgX64.dsc

All those platforms inherit FALSE for "PcdPciDisableBusEnumeration" from
"MdeModulePkg.dec".

This makes the PcdGetBool() call in the entry point of the driver
superfluous; remove it. Clean up now unused dependencies in the INF file
as well.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20210526201446.12554-28-lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
This commit is contained in:
Laszlo Ersek
2021-05-26 22:14:30 +02:00
committed by mergify[bot]
parent 8c8f886f27
commit 984c93ece3
2 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.c
View File

@@ -266,14 +266,10 @@ DriverInitialize (
VOID *Registration; VOID *Registration;
// //
// If the PCI Bus driver is not supposed to allocate resources, then it makes // If there is no 64-bit PCI MMIO aperture, then 64-bit MMIO BARs have to be
// no sense to install a protocol that influences the resource allocation. // allocated under 4 GB unconditionally.
// //
// Similarly, if there is no 64-bit PCI MMIO aperture, then 64-bit MMIO BARs if (PcdGet64 (PcdPciMmio64Size) == 0) {
// have to be allocated under 4 GB unconditionally.
//
if (PcdGetBool (PcdPciDisableBusEnumeration) ||
PcdGet64 (PcdPciMmio64Size) == 0) {
return EFI_UNSUPPORTED; return EFI_UNSUPPORTED;
} }

2
OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.inf
View File

@@ -20,7 +20,6 @@
IncompatiblePciDeviceSupport.c IncompatiblePciDeviceSupport.c
[Packages] [Packages]
MdeModulePkg/MdeModulePkg.dec
MdePkg/MdePkg.dec MdePkg/MdePkg.dec
OvmfPkg/OvmfPkg.dec OvmfPkg/OvmfPkg.dec
@@ -36,7 +35,6 @@
gEfiLegacyBiosProtocolGuid ## NOTIFY gEfiLegacyBiosProtocolGuid ## NOTIFY
[Pcd] [Pcd]
gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration ## CONSUMES
gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Size ## CONSUMES gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Size ## CONSUMES
[Depex] [Depex]