BaseTools/GenFds: cleanup GenFds
1) remove wildcard imports and use explicit imports 2) refactor to use shared variables from Common/DataType 3) rename to not shadow imports 4) don't assign a variable in a loop (just do final assignment) 5) remove spaces, parens, unused or commented out code, etc. 6) merge unnecessary parent classes into child 7) refactor to share DXE and PEI apriori GUIDs from one place this includes changes to Build and EOT files 8) for PEP8, dont use __ for custom methods. Cc: Yonghong Zhu <yonghong.zhu@intel.com> Cc: Liming Gao <liming.gao@intel.com> Cc: Bob C Feng <bob.c.feng@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.carsey@intel.com> Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
This commit is contained in:
committed by
Yonghong Zhu
parent
0019375fbc
commit
9e47e6f908
@ -37,50 +37,6 @@ class FDClassObject:
|
||||
self.RegionList = []
|
||||
self.vtfRawDict = {}
|
||||
|
||||
## FV data in FDF
|
||||
#
|
||||
#
|
||||
class FvClassObject:
|
||||
## The constructor
|
||||
#
|
||||
# @param self The object pointer
|
||||
#
|
||||
def __init__(self):
|
||||
self.UiFvName = None
|
||||
self.CreateFileName = None
|
||||
# 3-tuple list (blockSize, numBlocks, pcd)
|
||||
self.BlockSizeList = []
|
||||
# DefineVarDict[var] = value
|
||||
self.DefineVarDict = {}
|
||||
# SetVarDict[var] = value
|
||||
self.SetVarDict = {}
|
||||
self.FvAlignment = None
|
||||
# FvAttributeDict[attribute] = TRUE/FALSE (1/0)
|
||||
self.FvAttributeDict = {}
|
||||
self.FvNameGuid = None
|
||||
self.FvNameString = None
|
||||
self.AprioriSectionList = []
|
||||
self.FfsList = []
|
||||
self.BsBaseAddress = None
|
||||
self.RtBaseAddress = None
|
||||
|
||||
## Region data in FDF
|
||||
#
|
||||
#
|
||||
class RegionClassObject:
|
||||
## The constructor
|
||||
#
|
||||
# @param self The object pointer
|
||||
#
|
||||
def __init__(self):
|
||||
self.Offset = None # The begin position of the Region
|
||||
self.Size = None # The Size of the Region
|
||||
self.PcdOffset = None
|
||||
self.PcdSize = None
|
||||
self.SetVarDict = {}
|
||||
self.RegionType = None
|
||||
self.RegionDataList = []
|
||||
|
||||
## FFS data in FDF
|
||||
#
|
||||
#
|
||||
@ -112,7 +68,6 @@ class FileStatementClassObject (FfsClassObject) :
|
||||
self.FvName = None
|
||||
self.FdName = None
|
||||
self.DefineVarDict = {}
|
||||
self.AprioriSection = None
|
||||
self.KeepReloc = None
|
||||
|
||||
## INF statement data in FDF
|
||||
@ -134,19 +89,6 @@ class FfsInfStatementClassObject(FfsClassObject):
|
||||
self.KeepReloc = None
|
||||
self.UseArch = None
|
||||
|
||||
## APRIORI section data in FDF
|
||||
#
|
||||
#
|
||||
class AprioriSectionClassObject:
|
||||
## The constructor
|
||||
#
|
||||
# @param self The object pointer
|
||||
#
|
||||
def __init__(self):
|
||||
# DefineVarDict[var] = value
|
||||
self.DefineVarDict = {}
|
||||
self.FfsList = []
|
||||
|
||||
## section data in FDF
|
||||
#
|
||||
#
|
||||
@ -363,21 +305,6 @@ class CapsuleClassObject :
|
||||
self.CapsuleDataList = []
|
||||
self.FmpPayloadList = []
|
||||
|
||||
## VTF data in FDF
|
||||
#
|
||||
#
|
||||
class VtfClassObject :
|
||||
## The constructor
|
||||
#
|
||||
# @param self The object pointer
|
||||
#
|
||||
def __init__(self):
|
||||
self.KeyArch = None
|
||||
self.ArchList = None
|
||||
self.UiName = None
|
||||
self.ResetBin = None
|
||||
self.ComponentStatementList = []
|
||||
|
||||
## VTF component data in FDF
|
||||
#
|
||||
#
|
||||
|
Reference in New Issue
Block a user