sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

EmbeddedPkg: get rid of BdsLib dependency from Android*Boot

Browse Source 
The sum use these applications made of BdsLib was one invocation of the
IS_DEVICE_PATH_NODE macro, and (incorrectly) being able to leave out a
dependency on gEfiLoadedImageProtocolGuid.

So expand the macro in place and add the missing dependency.
Then clean up the .dsc, .inf and #includes accordingly.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
This commit is contained in:
Leif Lindholm
2017-11-25 13:16:20 +00:00
parent 1abf9f05de
commit a64d587294
5 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
EmbeddedPkg/Application/AndroidBoot/AndroidBootApp.c
View File

@ -15,7 +15,6 @@
#include <Library/AndroidBootImgLib.h>
#include <Library/BaseMemoryLib.h>
#include <Library/BdsLib.h>
#include <Library/DebugLib.h>
#include <Library/DevicePathLib.h>
#include <Library/MemoryAllocationLib.h>
@ -35,7 +34,8 @@ ValidateAndroidMediaDevicePath (
NextNode = DevicePath;
while (NextNode != NULL) {
Node = NextNode;
if (IS_DEVICE_PATH_NODE (Node, MEDIA_DEVICE_PATH, MEDIA_HARDDRIVE_DP)) {
if (Node->Type == MEDIA_DEVICE_PATH &&
Node->SubType == MEDIA_HARDDRIVE_DP) {
return EFI_SUCCESS;
}
NextNode = NextDevicePathNode (Node);

1
EmbeddedPkg/Application/AndroidBoot/AndroidBootApp.inf
View File

@ -28,7 +28,6 @@
AndroidBootImgLib
BaseLib
BaseMemoryLib
BdsLib
DebugLib
DevicePathLib
DxeServicesTableLib