sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QuarkSocPkg/Library: Remove extra UefiBaseType.h includes

Browse Source 
Based on Laszlo Ersek work to add ASSERT_RETURN_ERORR():

  https://lists.01.org/pipermail/edk2-devel/2016-October/003132.html

Laszlo also discovered libraries of type BASE that include
UefiBaseType.h that should not include that file:

  https://lists.01.org/pipermail/edk2-devel/2016-October/003308.html

This change removes the extra #include of <Uefi/UefiBaseType.h>
from QNCSmmLib.c.

Cc: Kelly Steele <kelly.steele@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
This commit is contained in:
Michael Kinney
2016-10-26 20:12:24 -07:00
parent 4d4b81697c
commit a6f5a5b51f
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c
View File

@ -1,7 +1,7 @@
/** @file /** @file
QNC Smm Library Services that implements SMM Region access, S/W SMI generation and detection. QNC Smm Library Services that implements SMM Region access, S/W SMI generation and detection.
Copyright (c) 2013-2015 Intel Corporation. Copyright (c) 2013-2016 Intel Corporation.
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
@ -19,7 +19,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
#include <Library/DebugLib.h> #include <Library/DebugLib.h>
#include <Library/PcdLib.h> #include <Library/PcdLib.h>
#include <Library/IoLib.h> #include <Library/IoLib.h>
#include <Uefi/UefiBaseType.h>
#include <Library/QNCAccessLib.h> #include <Library/QNCAccessLib.h>
#define BOOT_SERVICE_SOFTWARE_SMI_DATA 0 #define BOOT_SERVICE_SOFTWARE_SMI_DATA 0