Revert "ShellPkg: Add Shell[Get|Set]RawCmdLine to ShellCommandLib"
This reverts commit 0fcf8d4df8
.
The above commit causes several regression of "echo" command:
1. Double quotes are not being stripped from the final text. UEFI Shell 2.2 section 3.4.5 chops out the quotes.
2. Output redirection is not working as expected. Text is being redirected, but the ‘> …’ text should not be.
3. Inconsistent special character handling. For example, comments with # seem to be parsed out correctly, but handing of ^ is incorrect.
In summary, ‘echo “You are ^#1” > t.txt’ results in the below content in t.txt:
“You are ^#1” > t.txt
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Tapan Shah <tapandshah@hpe.com>
This commit is contained in:
@ -670,29 +670,6 @@ ShellFileHandleEof(
|
||||
IN SHELL_FILE_HANDLE Handle
|
||||
);
|
||||
|
||||
/**
|
||||
Function to get the original CmdLine string for current command.
|
||||
|
||||
@return A pointer to the buffer of the original command string.
|
||||
It's the caller's responsibility to free the buffer.
|
||||
**/
|
||||
CHAR16*
|
||||
EFIAPI
|
||||
ShellGetRawCmdLine (
|
||||
VOID
|
||||
);
|
||||
|
||||
/**
|
||||
Function to store the orgignal command string into mOriginalCmdLine.
|
||||
|
||||
@param[in] CmdLine the command line string to store.
|
||||
**/
|
||||
VOID
|
||||
EFIAPI
|
||||
ShellSetRawCmdLine (
|
||||
IN CONST CHAR16 *CmdLine
|
||||
);
|
||||
|
||||
typedef struct {
|
||||
LIST_ENTRY Link;
|
||||
void *Buffer;
|
||||
|
Reference in New Issue
Block a user