sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

EmbeddedPkg: AndroidBootApp: fix clang compilation

Browse Source 
Address an incorrect function prototype (using ; instead of ,)
in AndroidBootImg.h.

Also restructure code slightly to avoid a "may be used uninitialized"
warning.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
This commit is contained in:
Leif Lindholm
2017-12-06 17:29:26 +00:00
parent 80ee06cee7
commit ac811846f2
2 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
EmbeddedPkg/Include/Protocol/AndroidBootImg.h
View File

@ -33,8 +33,8 @@ EFI_STATUS
typedef typedef
EFI_STATUS EFI_STATUS
(EFIAPI *ANDROID_BOOTIMG_UPDATE_DTB) ( (EFIAPI *ANDROID_BOOTIMG_UPDATE_DTB) (
IN EFI_PHYSICAL_ADDRESS OrigDtbBase; IN EFI_PHYSICAL_ADDRESS OrigDtbBase,
OUT EFI_PHYSICAL_ADDRESS *NewDtbBase; OUT EFI_PHYSICAL_ADDRESS *NewDtbBase
); );
struct _ANDROID_BOOTIMG_PROTOCOL { struct _ANDROID_BOOTIMG_PROTOCOL {

9
EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c
View File

@ -357,12 +357,13 @@ AndroidBootImgUpdateFdt (
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
goto Fdt_Exit; goto Fdt_Exit;
} }
Status = gBS->InstallConfigurationTable (
&gFdtTableGuid,
(VOID *)(UINTN)NewFdtBase
);
} }
Status = gBS->InstallConfigurationTable (
&gFdtTableGuid,
(VOID *)(UINTN)NewFdtBase
);
if (!EFI_ERROR (Status)) { if (!EFI_ERROR (Status)) {
return EFI_SUCCESS; return EFI_SUCCESS;
} }