sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

NetworkPkg: IpSecDxe: Remove the redundant code.

Browse Source 
The functions that are never called have been removed.
They are Ikev2OnPacketAccepted, Ikev2SaSessionOnDeleting,
Ikev2ChildSaSessionLookupByMid, Ikev2ChildSaSessionOnDeleting
and Ikev2ChildExchangeRekeySpi.

Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Songpeng Li <songpeng.li@intel.com>
Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>
This commit is contained in:
Songpeng Li 2018-08-16 08:57:14 +08:00 committed by Jiaxin Wu
parent fafdb489a7
commit ad1e45ddb5
3 changed files with 0 additions and 161 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
NetworkPkg/IpSecDxe/Ikev2/Payload.c
View File

@ -3104,24 +3104,6 @@ ON_EXIT:
return Status; return Status;
} }
/**
Save some useful payloads after accepting the Packet.
@param[in] SessionCommon Pointer to IKEV2_SESSION_COMMON related to the operation.
@param[in] IkePacket Pointer to received IkePacet.
@param[in] IkeType The type used to indicate it is in IkeSa or ChildSa or Info
exchange.
**/
VOID
Ikev2OnPacketAccepted (
IN IKEV2_SESSION_COMMON *SessionCommon,
IN IKE_PACKET *IkePacket,
IN UINT8 IkeType
)
{
return;
}
/** /**

76
NetworkPkg/IpSecDxe/Ikev2/Utility.c
View File

@ -290,21 +290,6 @@ Ikev2SaSessionRemove (
return NULL; return NULL;
} }
/**
Marking a SA session as on deleting.
@param[in] IkeSaSession Pointer to IKEV2_SA_SESSION.
@retval EFI_SUCCESS Find the related SA session and marked it.
**/
EFI_STATUS
Ikev2SaSessionOnDeleting (
IN IKEV2_SA_SESSION *IkeSaSession
)
{
return EFI_SUCCESS;
}
/** /**
Free specified Seession Common. The session common would belong to a IKE SA or Free specified Seession Common. The session common would belong to a IKE SA or
@ -659,33 +644,6 @@ Ikev2ChildSaSessionReg (
return ; return ;
} }
/**
Find the ChildSaSession by it's MessagId.
@param[in] SaSessionList Pointer to a ChildSaSession List.
@param[in] Mid The messageId used to search ChildSaSession.
@return Pointer to IKEV2_CHILD_SA_SESSION or NULL.
**/
IKEV2_CHILD_SA_SESSION *
Ikev2ChildSaSessionLookupByMid (
IN LIST_ENTRY *SaSessionList,
IN UINT32 Mid
)
{
LIST_ENTRY *Entry;
IKEV2_CHILD_SA_SESSION *ChildSaSession;
NET_LIST_FOR_EACH (Entry, SaSessionList) {
ChildSaSession = IKEV2_CHILD_SA_SESSION_BY_IKE_SA (Entry);
if (ChildSaSession->MessageId == Mid) {
return ChildSaSession;
}
}
return NULL;
}
/** /**
This function find the Child SA by the specified SPI. This function find the Child SA by the specified SPI.
@ -776,22 +734,6 @@ Ikev2ChildSaSessionRemove (
return NULL; return NULL;
} }
/**
Mark a specified Child SA Session as on deleting.
@param[in] ChildSaSession Pointer to IKEV2_CHILD_SA_SESSION.
@retval EFI_SUCCESS Operation is successful.
**/
EFI_STATUS
Ikev2ChildSaSessionOnDeleting (
IN IKEV2_CHILD_SA_SESSION *ChildSaSession
)
{
return EFI_SUCCESS;
}
/** /**
Free the memory located for the specified IKEV2_CHILD_SA_SESSION. Free the memory located for the specified IKEV2_CHILD_SA_SESSION.
@ -1137,24 +1079,6 @@ Ikev2ChildSaAssociateSpdEntry (
} }
/**
This function finds the SPI from Create Child SA Exchange Packet.
@param[in] IkePacket Pointer to IKE_PACKET to be searched.
@retval SPI number or 0 if it is not supported.
**/
UINT32
Ikev2ChildExchangeRekeySpi (
IN IKE_PACKET *IkePacket
)
{
//
// Not support yet.
//
return 0;
}
/** /**
Validate the IKE header of received IKE packet. Validate the IKE header of received IKE packet.

67
NetworkPkg/IpSecDxe/Ikev2/Utility.h
View File

@ -104,19 +104,6 @@ Ikev2SaSessionRemove (
); );
/**
Marking a SA session as on deleting.
@param[in] IkeSaSession Pointer to IKEV2_SA_SESSION.
@retval EFI_SUCCESS Find the related SA session and marked it.
**/
EFI_STATUS
Ikev2SaSessionOnDeleting (
IN IKEV2_SA_SESSION *IkeSaSession
);
/** /**
After IKE/Child SA is estiblished, close the time event and free sent packet. After IKE/Child SA is estiblished, close the time event and free sent packet.
@ -211,20 +198,6 @@ Ikev2ChildSaSessionLookupBySpi (
IN UINT32 Spi IN UINT32 Spi
); );
/**
Find the ChildSaSession by it's MessagId.
@param[in] SaSessionList Pointer to a ChildSaSession List.
@param[in] Mid The messageId used to search ChildSaSession.
@return Pointer to IKEV2_CHILD_SA_SESSION.
**/
IKEV2_CHILD_SA_SESSION *
Ikev2ChildSaSessionLookupByMid (
IN LIST_ENTRY *SaSessionList,
IN UINT32 Mid
);
/** /**
Insert a Child SA Session into the specified ChildSa list.. Insert a Child SA Session into the specified ChildSa list..
@ -257,18 +230,6 @@ Ikev2ChildSaSessionRemove (
IN UINT8 ListType IN UINT8 ListType
); );
/**
Mark a specified Child SA Session as on deleting.
@param[in] ChildSaSession Pointer to IKEV2_CHILD_SA_SESSION.
@retval EFI_SUCCESS Operation is successful.
**/
EFI_STATUS
Ikev2ChildSaSessionOnDeleting (
IN IKEV2_CHILD_SA_SESSION *ChildSaSession
);
/** /**
Free the memory located for the specified IKEV2_CHILD_SA_SESSION. Free the memory located for the specified IKEV2_CHILD_SA_SESSION.
@ -328,19 +289,6 @@ Ikev2ChildExchangeRequestType(
IN IKE_PACKET *IkePacket IN IKE_PACKET *IkePacket
); );
/**
This function finds the SPI from Create Child Sa Exchange Packet.
@param[in] IkePacket Pointer to IKE_PACKET to be searched.
@retval SPI number.
**/
UINT32
Ikev2ChildExchangeRekeySpi(
IN IKE_PACKET *IkePacket
);
/** /**
Associate a SPD selector to the Child SA Session. Associate a SPD selector to the Child SA Session.
@ -882,21 +830,6 @@ Ikev2DecodePacket (
IN UINTN IkeType IN UINTN IkeType
); );
/**
Save some useful payloads after accepting the Packet.
@param[in] SessionCommon Pointer to IKEV2_SESSION_COMMON related to the operation.
@param[in] IkePacket Pointer to received IkePacet.
@param[in] IkeType The type used to indicate it is in IkeSa or ChildSa or Info
exchange.
**/
VOID
Ikev2OnPacketAccepted (
IN IKEV2_SESSION_COMMON *SessionCommon,
IN IKE_PACKET *IkePacket,
IN UINT8 IkeType
);
/** /**
Send out IKEV2 packet. Send out IKEV2 packet.