From af82ca4560a5c2ef4286bad767cab3cfe7c115dd Mon Sep 17 00:00:00 2001 From: Jiaxin Wu Date: Wed, 16 Jan 2019 10:54:42 +0800 Subject: [PATCH] NetworkPkg/IScsiDxe: Remove unnecessary NULL pointer check. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1469 Since the value of AttemptConfigData is retrieved from the list Entry, it can't be the NULL pointer, so just remove the unnecessary check. Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Hao A Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wu Jiaxin Reviewed-by: Wu Hao A Reviewed-by: Fu Siyuan --- NetworkPkg/IScsiDxe/IScsiConfig.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c b/NetworkPkg/IScsiDxe/IScsiConfig.c index 83644f51d8..78135b411c 100644 --- a/NetworkPkg/IScsiDxe/IScsiConfig.c +++ b/NetworkPkg/IScsiDxe/IScsiConfig.c @@ -1,7 +1,7 @@ /** @file Helper functions for configuring or getting the parameters relating to iSCSI. -Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2004 - 2019, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -2292,10 +2292,6 @@ IScsiConfigDeleteAttempts ( // AttemptConfigData = NET_LIST_USER_STRUCT (Entry, ISCSI_ATTEMPT_CONFIG_NVDATA, Link); - if (AttemptConfigData == NULL) { - Status = EFI_NOT_FOUND; - goto Error; - } // // Remove this attempt from UI configured attempt list.