sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Vlv2TbltDevicePkg/FvbRuntimeDxe: correct NumOfLba vararg type in EraseBlocks()

Browse Source 
According to the PI spec, Volume 3,
EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks():

> The variable argument list is a list of tuples. Each tuple describes a
> range of LBAs to erase and consists of the following:
> * An EFI_LBA that indicates the starting LBA
> * A UINTN that indicates the number of blocks to erase

(NB, in edk2, EFI_FIRMWARE_VOLUME_BLOCK_PROTOCOL is a typedef to
EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.)

In this driver, the NumOfLba local variable is defined with type UINTN,
but the TYPE argument passed to VA_ARG() is UINT32. Fix the mismatch.

Cc: David Wei <david.wei@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Mang Guo <mang.guo@intel.com>
Reported-by: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
This commit is contained in:
Laszlo Ersek
2017-05-18 23:04:27 +08:00
committed by zwei4
parent 687bde9cac
commit aff463c825
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbService.c
View File

@@ -793,7 +793,7 @@ FvbProtocolEraseBlocks (
if (FwhInstance != NULL) { if (FwhInstance != NULL) {
NumOfBlocks = FwhInstance->NumOfBlocks; NumOfBlocks = FwhInstance->NumOfBlocks;
} }
VA_START (args, This); VA_START (args, This);
do { do {
@@ -817,7 +817,7 @@ FvbProtocolEraseBlocks (
} }
} while ( 1 ); } while ( 1 );
VA_END (args); VA_END (args);
VA_START (args, This); VA_START (args, This);
do { do {

4
Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbSmmDxe.c
View File

@@ -725,7 +725,7 @@ FvbEraseBlocks (
Status = EFI_SUCCESS; Status = EFI_SUCCESS;
// //
// Check the parameter. // Check the parameter.
// //
VA_START (Marker, This); VA_START (Marker, This);
do { do {
@@ -742,7 +742,7 @@ FvbEraseBlocks (
} while ( 1 ); } while ( 1 );
VA_END (Marker); VA_END (Marker);
// //
// Erase the blocks. // Erase the blocks.
// //
VA_START (Marker, This); VA_START (Marker, This);