From b4dc05e854736c8f353a0f6e18ca85faa4d3785e Mon Sep 17 00:00:00 2001 From: Hao Wu Date: Wed, 16 Nov 2016 16:35:56 +0800 Subject: [PATCH] BaseTools/BuildEnv: Do not modify the env 'PACKAGES_PATH' in BuildEnv https://bugzilla.tianocore.org/show_bug.cgi?id=236 The script 'BuildEnv' modifies the value of the environment variable 'PACKAGES_PATH' (line 44). The script will substitute the ':' symbol (separating multiple paths) with a space. This is not supposed to happen since users might later use 'PACKAGES_PATH' during the code-building process under a multiple-workspace scenario. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu Reviewed-by: Liming Gao --- BaseTools/BuildEnv | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/BaseTools/BuildEnv b/BaseTools/BuildEnv index cb6403a52b..f74881111c 100755 --- a/BaseTools/BuildEnv +++ b/BaseTools/BuildEnv @@ -2,7 +2,7 @@ # Setup the environment for unix-like systems running a bash-like shell. # This file must be "sourced" not merely executed. For example: ". edksetup.sh" # -# Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
+# Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
# Copyright (c) 2016, Linaro Ltd. All rights reserved.
# This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License @@ -41,8 +41,8 @@ RestorePreviousConfiguration() { export CONF_PATH=$WORKSPACE/Conf if [ ! -d $WORKSPACE/Conf ] && [ -n "$PACKAGES_PATH" ] then - PACKAGES_PATH=${PACKAGES_PATH//:/ } - for DIR in $PACKAGES_PATH + PATH_LIST=${PACKAGES_PATH//:/ } + for DIR in $PATH_LIST do if [ -d $DIR/Conf ] then @@ -138,8 +138,8 @@ SetEdkToolsPath() { # if [ -n "$PACKAGES_PATH"] then - PACKAGES_PATH=${PACKAGES_PATH//:/ } - for DIR in $PACKAGES_PATH + PATH_LIST=${PACKAGES_PATH//:/ } + for DIR in $PATH_LIST do if [ -d $DIR/BaseTools ] then