sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CryptoPkg/BaseCryptLib: remove some duplicate initializations.

Browse Source 
clang-analyzer noticed this:

Pk/CryptPkcs7Verify.c:600:5: warning: Value stored to 'OldSize' is never read
    OldSize    = BufferSize;
    ^            ~~~~~~~~~~
Pk/CryptPkcs7Verify.c:644:5: warning: Value stored to 'OldSize' is never read
    OldSize    = BufferSize;
    ^            ~~~~~~~~~~
2 warnings generated.

These are each immediately followed by a loop that initializes them (to
the same values) a second time, and are otherwise only referenced inside
that loop, so there's just no point to these assignments at all.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Peter Jones <pjones@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Long Qin <qin.long@intel.com>
This commit is contained in:
Peter Jones
2017-10-20 23:10:18 +08:00
committed by Long Qin
parent 34cd44d4de
commit b5a985ca92
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c
View File

@@ -612,7 +612,6 @@ Pkcs7GetCertificatesList (
if (CtxChain != NULL) { if (CtxChain != NULL) {
BufferSize = sizeof (UINT8); BufferSize = sizeof (UINT8);
OldSize = BufferSize;
CertBuf = NULL; CertBuf = NULL;
for (Index = 0; ; Index++) { for (Index = 0; ; Index++) {
@@ -656,7 +655,6 @@ Pkcs7GetCertificatesList (
if (CtxUntrusted != NULL) { if (CtxUntrusted != NULL) {
BufferSize = sizeof (UINT8); BufferSize = sizeof (UINT8);
OldSize = BufferSize;
CertBuf = NULL; CertBuf = NULL;
for (Index = 0; ; Index++) { for (Index = 0; ; Index++) {