sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BaseTools: sets are faster to check via "in" due to hashing

Browse Source 
switch list to set:
1)we dont care about order
2)we only check for membership.

then remove ".keys()" from dict looping:
allow generators opportunity to optimize

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
This commit is contained in:
Carsey, Jaben
2018-04-06 07:13:52 +08:00
committed by Yonghong Zhu
parent a993dc03ab
commit b74b419a01
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
BaseTools/Source/Python/AutoGen/AutoGen.py
View File

@ -365,9 +365,9 @@ class WorkspaceAutoGen(AutoGen):
MetaFile_cache = {} MetaFile_cache = {}
for Arch in self.ArchList: for Arch in self.ArchList:
Platform_cache[Arch] = self.BuildDatabase[self.MetaFile, Arch, Target, Toolchain] Platform_cache[Arch] = self.BuildDatabase[self.MetaFile, Arch, Target, Toolchain]
MetaFile_cache[Arch] = [] MetaFile_cache[Arch] = set()
for Pkey in Platform_cache[Arch].Modules.keys(): for Pkey in Platform_cache[Arch].Modules:
MetaFile_cache[Arch].append(Platform_cache[Arch].Modules[Pkey].MetaFile) MetaFile_cache[Arch].add(Platform_cache[Arch].Modules[Pkey].MetaFile)
for Inf in self.FdfProfile.InfDict[key]: for Inf in self.FdfProfile.InfDict[key]:
ModuleFile = PathClass(NormPath(Inf), GlobalData.gWorkspace, Arch) ModuleFile = PathClass(NormPath(Inf), GlobalData.gWorkspace, Arch)
for Arch in self.ArchList: for Arch in self.ArchList:
@ -382,9 +382,9 @@ class WorkspaceAutoGen(AutoGen):
for Arch in self.ArchList: for Arch in self.ArchList:
if Arch == key: if Arch == key:
Platform = self.BuildDatabase[self.MetaFile, Arch, Target, Toolchain] Platform = self.BuildDatabase[self.MetaFile, Arch, Target, Toolchain]
MetaFileList = [] MetaFileList = set()
for Pkey in Platform.Modules.keys(): for Pkey in Platform.Modules:
MetaFileList.append(Platform.Modules[Pkey].MetaFile) MetaFileList.add(Platform.Modules[Pkey].MetaFile)
for Inf in self.FdfProfile.InfDict[key]: for Inf in self.FdfProfile.InfDict[key]:
ModuleFile = PathClass(NormPath(Inf), GlobalData.gWorkspace, Arch) ModuleFile = PathClass(NormPath(Inf), GlobalData.gWorkspace, Arch)
if ModuleFile in MetaFileList: if ModuleFile in MetaFileList: