sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove SafeFreePool from MemoryAllocationLib as this API's name is misleading. Its implementation only check if a pointer is NULL. If a garbage pointer is passed in, the gBS->FreePool will still ASSERT in debug build and return error code.

Browse Source 
It is recommended that module writer should keep track how a pointer is allocated and free it after use.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6305 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
qwang12
2008-10-30 07:31:31 +00:00
parent 34abfd7cf8
commit bb1d8ee669
3 changed files with 0 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
MdePkg/Include/Library/MemoryAllocationLib.h
View File

@ -383,18 +383,4 @@ FreePool (
IN VOID *Buffer IN VOID *Buffer
); );
/**
Frees buffer that were previously allocated with one of the
memory allocation functions in the Memory Allocation Library.
@param Buffer Pointer to the buffer of pages
to free.
**/
VOID
EFIAPI
SafeFreePool (
IN VOID *Buffer
);
#endif #endif

19
MdePkg/Library/PeiMemoryAllocationLib/MemoryAllocationLib.c
View File

@ -650,22 +650,3 @@ FreePool (
} }
/**
Frees buffer that were previously allocated with one of the
memory allocation functions in the Memory Allocation Library.
@param Buffer Pointer to the buffer of pages
to free.
**/
VOID
EFIAPI
SafeFreePool (
IN VOID *Buffer
)
{
//
// PEI phase does not support to free pool, so leave it as NOP.
//
}

20
MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c
View File

@ -667,23 +667,3 @@ FreePool (
ASSERT_EFI_ERROR (Status); ASSERT_EFI_ERROR (Status);
} }
/**
Frees buffer that were previously allocated with one of the
memory allocation functions in the Memory Allocation Library.
@param Buffer Pointer to the buffer of pages
to free.
**/
VOID
EFIAPI
SafeFreePool (
IN VOID *Buffer
)
{
if (Buffer != NULL) {
FreePool (Buffer);
}
}