UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiServices table.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1972 AP calls CollectProcessorData() to collect processor info. CollectProcessorData function finally calls PcdGetSize function to get DynamicPCD PcdCpuFeaturesSetting value. PcdGetSize will use PeiServices table which caused below assert info: Processor Info: Package: 1, MaxCore : 4, MaxThread: 1 Package: 0, Valid Core : 4 ASSERT [CpuFeaturesPei] c:\projects\jsl\jsl_v1193\Edk2\MdePkg\Library \PeiServicesTablePointerLibIdt\PeiServicesTablePointer.c(48): PeiServices != ((void *) 0) This change uses saved global pcd size instead of calls PcdGetSize to fix this issue. Cc: Ray Ni <ray.ni@intel.com> Cc: Laszlo Ersek <lersek@redhat.com> Cc: Chandana Kumar <chandana.c.kumar@intel.com> Cc: Star Zeng <star.zeng@intel.com> Signed-off-by: Eric Dong <eric.dong@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Reviewed-by: Star Zeng <star.zeng@intel.com>
This commit is contained in:
@@ -658,6 +658,11 @@ RegisterCpuFeatureWorker (
|
||||
InitializeListHead (&CpuFeaturesData->FeatureList);
|
||||
InitializeSpinLock (&CpuFeaturesData->CpuFlags.MemoryMappedLock);
|
||||
InitializeSpinLock (&CpuFeaturesData->CpuFlags.ConsoleLogLock);
|
||||
//
|
||||
// Driver has assumption that these three PCD should has same buffer size.
|
||||
//
|
||||
ASSERT (PcdGetSize (PcdCpuFeaturesSetting) == PcdGetSize (PcdCpuFeaturesCapability));
|
||||
ASSERT (PcdGetSize (PcdCpuFeaturesSetting) == PcdGetSize (PcdCpuFeaturesSupport));
|
||||
CpuFeaturesData->BitMaskSize = (UINT32) BitMaskSize;
|
||||
}
|
||||
ASSERT (CpuFeaturesData->BitMaskSize == BitMaskSize);
|
||||
|
Reference in New Issue
Block a user