sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MdePkg/BaseLib: Add an additional check within AsciiStriCmp

Browse Source 
This commit adds an addtional check in AsciiStriCmp. It
explicitly checks the end of the sting pointed by 'SecondString' to make
the code logic easier for reading and to prevent possible mis-reports by
static code checkers.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Hao Wu <Hao.a.wu@intel.com>
This commit is contained in:
Ruiyu Ni
2018-08-03 10:42:45 +08:00
parent 526dd0245b
commit c1f032cd3a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
MdePkg/Library/BaseLib/String.c
View File

@@ -1262,7 +1262,7 @@ AsciiStriCmp (
UpperFirstString = InternalBaseLibAsciiToUpper (*FirstString); UpperFirstString = InternalBaseLibAsciiToUpper (*FirstString);
UpperSecondString = InternalBaseLibAsciiToUpper (*SecondString); UpperSecondString = InternalBaseLibAsciiToUpper (*SecondString);
while ((*FirstString != '\0') && (UpperFirstString == UpperSecondString)) { while ((*FirstString != '\0') && (*SecondString != '\0') && (UpperFirstString == UpperSecondString)) {
FirstString++; FirstString++;
SecondString++; SecondString++;
UpperFirstString = InternalBaseLibAsciiToUpper (*FirstString); UpperFirstString = InternalBaseLibAsciiToUpper (*FirstString);