sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MdeModulePkg EhciPei: Minor refinement about IOMMU

Browse Source 
This patch is following 2c656af04d7f.
1. Fix typo "XHC" to "EHC".
2. Reinitialize Request(Phy/Map) and Data(Phy/Map)
in Urb, otherwise the last time value of them may
be used in error handling when error happens.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
This commit is contained in:
Star Zeng 2017-11-20 15:44:24 +08:00
parent a8035b9086
commit c34a5aab53
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
MdeModulePkg/Bus/Pci/EhciPei/EhcPeim.h
View File

@ -99,7 +99,7 @@ struct _PEI_USB2_HC_DEV {
EDKII_IOMMU_PPI *IoMmu; EDKII_IOMMU_PPI *IoMmu;
EFI_PEI_PPI_DESCRIPTOR PpiDescriptor; EFI_PEI_PPI_DESCRIPTOR PpiDescriptor;
// //
// EndOfPei callback is used to stop the XHC DMA operation // EndOfPei callback is used to stop the EHC DMA operation
// after exit PEI phase. // after exit PEI phase.
// //
EFI_PEI_NOTIFY_DESCRIPTOR EndOfPeiNotifyList; EFI_PEI_NOTIFY_DESCRIPTOR EndOfPeiNotifyList;

13
MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c
View File

@ -576,7 +576,12 @@ EhcCreateUrb (
if (Urb->Qh == NULL) { if (Urb->Qh == NULL) {
goto ON_ERROR; goto ON_ERROR;
} }
Urb->RequestPhy = NULL;
Urb->RequestMap = NULL;
Urb->DataPhy = NULL;
Urb->DataMap = NULL;
// //
// Map the request and user data // Map the request and user data
// //
@ -591,9 +596,6 @@ EhcCreateUrb (
Urb->RequestPhy = (VOID *) ((UINTN) PhyAddr); Urb->RequestPhy = (VOID *) ((UINTN) PhyAddr);
Urb->RequestMap = Map; Urb->RequestMap = Map;
} else {
Urb->RequestPhy = NULL;
Urb->RequestMap = NULL;
} }
if (Data != NULL) { if (Data != NULL) {
@ -613,9 +615,6 @@ EhcCreateUrb (
Urb->DataPhy = (VOID *) ((UINTN) PhyAddr); Urb->DataPhy = (VOID *) ((UINTN) PhyAddr);
Urb->DataMap = Map; Urb->DataMap = Map;
} else {
Urb->DataPhy = NULL;
Urb->DataMap = NULL;
} }
Status = EhcCreateQtds (Ehc, Urb); Status = EhcCreateQtds (Ehc, Urb);