sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MdePkg: Follow PI1.4a to fix artificial limitation of SkuId range

Browse Source 
There is absolutely no reason to artificially limit the SKU range to 1-255.
PI1.4a spec fixed the artificial limitation.

This patch is to follow PI1.4a spec to remove PCD_MAX_SKU_ID definition,
the check to PCD_MAX_SKU_ID and the comments describes the limitation.

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
This commit is contained in:
Star Zeng
2016-05-20 12:20:04 +08:00
parent 120ca3ceae
commit c745144407
4 changed files with 6 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
MdePkg/Library/DxePcdLib/DxePcdLib.c
View File

@@ -1,7 +1,7 @@
/** @file
Implementation of PcdLib class library for DXE phase.
Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -125,7 +125,6 @@ GetPcdInfoProtocolPointer (
This function provides a means by which SKU support can be established in the PCD infrastructure.
Sets the current SKU in the PCD database to the value specified by SkuId. SkuId is returned.
If SkuId >= PCD_MAX_SKU_ID, then ASSERT().
@param SkuId The SKU value that will be used when the PCD service retrieves and sets values
associated with a PCD token.
@@ -139,8 +138,6 @@ LibPcdSetSku (
IN UINTN SkuId
)
{
ASSERT (SkuId < PCD_MAX_SKU_ID);
GetPcdProtocol()->SetSku (SkuId);
return SkuId;
@@ -1614,8 +1611,6 @@ LibPcdGetInfoEx (
/**
Retrieve the currently set SKU Id.
If the sku id got >= PCD_MAX_SKU_ID, then ASSERT().
@return The currently set SKU Id. If the platform has not set at a SKU Id, then the
default SKU Id value of 0 is returned. If the platform has set a SKU Id, then the currently set SKU
Id is returned.
@@ -1626,11 +1621,6 @@ LibPcdGetSku (
VOID
)
{
UINTN SkuId;
SkuId = GetPiPcdInfoProtocolPointer()->GetSku ();
ASSERT (SkuId < PCD_MAX_SKU_ID);
return SkuId;
return GetPiPcdInfoProtocolPointer()->GetSku ();
}