sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

OvmfPkg/MemEncryptSevLib: clean up SetMemoryEncDec() comment block

Browse Source 
Document the "Cr3BaseAddress" parameter, and correct several parameter
references.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Tested-by: Brijesh Singh <brijesh.singh@amd.com>
Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
This commit is contained in:
Laszlo Ersek 2018-03-01 15:10:04 +01:00
parent 154dcd6c58
commit cde8c56809
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c
View File

@ -548,21 +548,23 @@ EnableReadOnlyPageWriteProtect (
/** /**
This function either sets or clears memory encryption bit for the memory This function either sets or clears memory encryption bit for the memory
region specified by PhysicalAddress and length from the current page table region specified by PhysicalAddress and Length from the current page table
context. context.
The function iterates through the physicalAddress one page at a time, and set The function iterates through the PhysicalAddress one page at a time, and set
or clears the memory encryption mask in the page table. If it encounters or clears the memory encryption mask in the page table. If it encounters
that a given physical address range is part of large page then it attempts to that a given physical address range is part of large page then it attempts to
change the attribute at one go (based on size), otherwise it splits the change the attribute at one go (based on size), otherwise it splits the
large pages into smaller (e.g 2M page into 4K pages) and then try to set or large pages into smaller (e.g 2M page into 4K pages) and then try to set or
clear the encryption bit on the smallest page size. clear the encryption bit on the smallest page size.
@param[in] Cr3BaseAddress Cr3 Base Address (if zero then use
current CR3)
@param[in] PhysicalAddress The physical address that is the start @param[in] PhysicalAddress The physical address that is the start
address of a memory region. address of a memory region.
@param[in] Length The length of memory region @param[in] Length The length of memory region
@param[in] Mode Set or Clear mode @param[in] Mode Set or Clear mode
@param[in] Flush Flush the caches before applying the @param[in] CacheFlush Flush the caches before applying the
encryption mask encryption mask
@retval RETURN_SUCCESS The attributes were cleared for the @retval RETURN_SUCCESS The attributes were cleared for the