From ce37f459550f6e4c9bae27a9a6c39ba8eaf6749f Mon Sep 17 00:00:00 2001 From: Kun Qin Date: Wed, 26 Jan 2022 03:39:06 +0800 Subject: [PATCH] ArmPkg: MmCommunicationDxe: MM communicate function argument attributes Current MM communicate2 function from ArmPkg described input arguments `CommBufferPhysical`, `CommBufferVirtual` and `CommSize` as input only, which mismatches with the "input and output type" as in PI specification. This change updated function descriptions of MM communite2 to match input argument types. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Bret Barkelew Cc: Michael Kubacki Cc: Sami Mujawar Signed-off-by: Kun Qin Reviewed-by: Sami Mujawar --- ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c index 7c8284104d..7f756a32d4 100644 --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c @@ -41,12 +41,13 @@ STATIC EFI_HANDLE mMmCommunicateHandle; This function provides a service to send and receive messages from a registered UEFI service. - @param[in] This The EFI_MM_COMMUNICATION_PROTOCOL instance. - @param[in] CommBufferPhysical Physical address of the MM communication buffer - @param[in] CommBufferVirtual Virtual address of the MM communication buffer - @param[in] CommSize The size of the data buffer being passed in. On exit, the size of data - being returned. Zero if the handler does not wish to reply with any data. - This parameter is optional and may be NULL. + @param[in] This The EFI_MM_COMMUNICATION_PROTOCOL instance. + @param[in, out] CommBufferPhysical Physical address of the MM communication buffer + @param[in, out] CommBufferVirtual Virtual address of the MM communication buffer + @param[in, out] CommSize The size of the data buffer being passed in. On exit, the + size of data being returned. Zero if the handler does not + wish to reply with any data. This parameter is optional + and may be NULL. @retval EFI_SUCCESS The message was successfully posted. @retval EFI_INVALID_PARAMETER CommBufferPhysical was NULL or CommBufferVirtual was NULL.