From cf2bde63a1a8fb5e63b17a01862b4a58e97212a3 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Thu, 1 Nov 2018 11:41:27 -0500 Subject: [PATCH] Revert "MdeModulePkg/SdMmcPciHcDxe: Execute card detect only for RemovableSlot" This reverts commit 4cd9d7fc6f2ece01a46f2156ba009e83a2951907. card detect causes hangs on many devices with a directly-attached SD card reader --- .../Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c index a87f8deb8c..008c0589df 100644 --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c @@ -672,18 +672,12 @@ SdMmcPciHcDriverBindingStart ( // // Check whether there is a SD/MMC card attached // - if (Private->Slot[Slot].SlotType == RemovableSlot) { - Status = SdMmcHcCardDetect (PciIo, Slot, &MediaPresent); - if (EFI_ERROR (Status) && (Status != EFI_MEDIA_CHANGED)) { - continue; - } else if (!MediaPresent) { - DEBUG (( - DEBUG_INFO, - "SdMmcHcCardDetect: No device attached in Slot[%d]!!!\n", - Slot - )); - continue; - } + Status = SdMmcHcCardDetect (PciIo, Slot, &MediaPresent); + if (EFI_ERROR (Status) && (Status != EFI_MEDIA_CHANGED)) { + continue; + } else if (!MediaPresent) { + DEBUG ((DEBUG_INFO, "SdMmcHcCardDetect: No device attached in Slot[%d]!!!\n", Slot)); + continue; } Status = SdMmcHcInitHost (Private, Slot);