sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ShellPkg SmbiosView: Eliminate trailing " | " in PrintBitsInfo()

Browse Source 
Current PrintBitsInfo() will always print an additional trailing
" | " for the bit flags, for example,

Base Board Feature Flags: Hosting board |  Replaceable |

Th patch is to eliminate trailing " | " in PrintBitsInfo(), then
the output will be like below

Base Board Feature Flags: Hosting board |  Replaceable

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
This commit is contained in:
Star Zeng
2017-01-18 16:53:33 +08:00
parent 4b5d69d302
commit d4c109da73
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
View File

@ -3449,19 +3449,24 @@ PrintBitsInfo (
UINTN Index; UINTN Index;
UINT32 Value; UINT32 Value;
BOOLEAN NoInfo; BOOLEAN FirstInfo;
NoInfo = TRUE; FirstInfo = TRUE;
Value = Bits; Value = Bits;
// //
// query the table and print information // query the table and print information
// //
for (Index = 0; Index < Number; Index++) { for (Index = 0; Index < Number; Index++) {
if (BIT (Value, Table[Index].Key) != 0) { if (BIT (Value, Table[Index].Key) != 0) {
if (!FirstInfo) {
//
// If it is not first info, print the separator first.
//
Print (L" | ");
}
Print (Table[Index].Info); Print (Table[Index].Info);
Print (L" | ");
NoInfo = FALSE; FirstInfo = FALSE;
// //
// clear the bit, for reserved bits test // clear the bit, for reserved bits test
// //
@ -3469,7 +3474,10 @@ PrintBitsInfo (
} }
} }
if (NoInfo) { //
// There is no any info if FirstInfo is still TRUE.
//
if (FirstInfo) {
ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_QUERYTABLE_NO_INFO), gShellDebug1HiiHandle); ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_QUERYTABLE_NO_INFO), gShellDebug1HiiHandle);
} }