sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add comment for modules which have external input.

Browse Source 
signed-off-by: jiewen.yao@intel.com
reviewed-by: guo.dong@intel.com
reviewed-by: ting.ye@intel.com
reviewed-by: liming.gao@intel.com
reviewed-by: elvin.li@intel.com



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13446 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
jyao1
2012-06-12 08:28:43 +00:00
parent 90eaa3c1e0
commit dc204d5a0f
30 changed files with 435 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
View File

@@ -3,7 +3,12 @@
#
# Capsule update module supports EFI and UEFI.
#
# Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>
# Caution: This module requires additional review when modified.
# This driver will have external input - capsule image.
# This external input must be validated carefully to avoid security issue like
# buffer overflow, integer overflow.
#
# Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.<BR>
#
# This program and the accompanying materials
# are licensed and made available under the terms and conditions

5
MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf
View File

@@ -4,6 +4,11 @@
# The X64 entrypoint to process capsule in long mode.
# This module is built as X64.
#
# Caution: This module requires additional review when modified.
# This driver will have external input - capsule image.
# This external input must be validated carefully to avoid security issue like
# buffer overflow, integer overflow.
#
# Copyright (c) 2011 - 2012, Intel Corporation. All rights reserved.<BR>
#
# This program and the accompanying materials

12
MdeModulePkg/Universal/CapsulePei/Common/CapsuleCoalesce.c
View File

@@ -1,6 +1,14 @@
/** @file
The logic to process capsule.
Caution: This module requires additional review when modified.
This driver will have external input - capsule image.
This external input must be validated carefully to avoid security issue like
buffer overflow, integer overflow.
CapsuleDataCoalesce() will do basic validation before coalesce capsule data
into memory.
Copyright (c) 2011 - 2012, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
@@ -792,6 +800,10 @@ BuildCapsuleDescriptors (
| PrivateDataDesc 0 |
MemBase ---->+---------------------------+<----- BlockList
Caution: This function may receive untrusted input.
The capsule data is external input, so this routine will do basic validation before
coalesce capsule data into memory.
@param PeiServices General purpose services available to every PEIM.
@param BlockListBuffer Point to the buffer of Capsule Descriptor Variables.
@param MemoryBase Pointer to the base of a block of memory that we can walk