sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

DynamicTablesPkg: AmlLib\AmlDbgPrint fix ECC error

Browse Source 
Fix ECC error 8001 reported errors in AmlDbgPrint.
  [8001] Only capital letters are allowed to be used
         for #define declarations.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
This commit is contained in:
Sami Mujawar
2020-09-21 18:19:55 +01:00
committed by mergify[bot]
parent 5e0b708f74
commit e18bc21d6a
8 changed files with 55 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint.c
View File

@@ -163,11 +163,11 @@ AmlDbgPrintNameString (
}
if (SegCount != 0) {
AmlDbgPrintNameSeg (Buffer);
AMLDBG_PRINT_NAMESEG (Buffer);
Buffer += AML_NAME_SEG_SIZE;
for (Index = 0; Index < SegCount - 1; Index++) {
DEBUG ((DEBUG_INFO, "."));
AmlDbgPrintNameSeg (Buffer);
AMLDBG_PRINT_NAMESEG (Buffer);
Buffer += AML_NAME_SEG_SIZE;
}
}
@@ -232,7 +232,7 @@ AmlDbgPrintDataNode (
if ((DataNode->DataType == EAmlNodeDataTypeNameString) ||
(DataNode->DataType == EAmlNodeDataTypeString)) {
AmlDbgPrintChars (
AMLDBG_PRINT_CHARS (
DEBUG_INFO,
(CONST CHAR8*)DataNode->Buffer,
DataNode->Size
@@ -316,7 +316,7 @@ AmlDbgPrintObjectNode (
DEBUG ((DEBUG_INFO, "0x%08x | ", ObjectNode->AmlByteEncoding->Attribute));
DEBUG ((DEBUG_INFO, "0x%04x | ", ObjectNode->PkgLen));
if (AmlNodeHasAttribute (ObjectNode, AML_IN_NAMESPACE)) {
AmlDbgPrintNameString (
AMLDBG_PRINT_NAMESTR (
AmlNodeGetName ((CONST AML_OBJECT_NODE*)ObjectNode),
FALSE
);
@@ -488,7 +488,7 @@ AmlDbgPrintTree (
**/
VOID
EFIAPI
DumpRaw (
AmlDbgDumpRaw (
IN CONST UINT8 * Ptr,
IN UINT32 Length
)

40
DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint.h
View File

@@ -45,7 +45,7 @@
**/
VOID
EFIAPI
DumpRaw (
AmlDbgDumpRaw (
IN CONST UINT8 * Ptr,
IN UINT32 Length
);
@@ -133,21 +133,45 @@ AmlDbgPrintNameSpace (
IN AML_ROOT_NODE_HANDLE RootNode
);
/* Macros to encapsulate Aml Debug Print APIs.
*/
#define AMLDBG_DUMP_RAW(Ptr, Length) \
AmlDbgDumpRaw (Ptr, Length)
#define AMLDBG_PRINT_CHARS(ErrorLevel, Buffer, Size) \
AmlDbgPrintChars (ErrorLevel, Buffer, Size)
#define AMLDBG_PRINT_NAMESEG(Buffer) \
AmlDbgPrintNameSeg (Buffer)
#define AMLDBG_PRINT_NAMESTR(Buffer,NewLine) \
AmlDbgPrintNameString (Buffer,NewLine)
#define AMLDBG_PRINT_NODE(Node) \
AmlDbgPrintNode (Node)
#define AMLDBG_PRINT_TREE(Node) \
AmlDbgPrintTree (Node)
#define AMLDBG_PRINT_NAMESPACE(RootNode) \
AmlDbgPrintNameSpace (RootNode)
#else
#define DumpRaw(Ptr, Length)
#define AMLDBG_DUMP_RAW(Ptr, Length)
#define AmlDbgPrintChars(ErrorLevel, Buffer, Size)
#define AMLDBG_PRINT_CHARS(ErrorLevel, Buffer, Size)
#define AmlDbgPrintNameSeg(Buffer)
#define AMLDBG_PRINT_NAMESEG(Buffer)
#define AmlDbgPrintNameString(Buffer,NewLine)
#define AMLDBG_PRINT_NAMESTR(Buffer,NewLine)
#define AmlDbgPrintNode(Node)
#define AMLDBG_PRINT_NODE(Node)
#define AmlDbgPrintTree(Node)
#define AMLDBG_PRINT_TREE(Node)
#define AmlDbgPrintNameSpace(RootNode)
#define AMLDBG_PRINT_NAMESPACE(RootNode)
#endif // MDEPKG_NDEBUG