sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refine new library instances according to review comments.

Browse Source 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6692 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
xli24
2008-11-24 05:55:41 +00:00
parent 519f076a47
commit e43e4b3e8c
13 changed files with 77 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
MdePkg/Library/UefiSalLib/UefiSalLib.c
View File

@@ -1,5 +1,6 @@
/** @file
SAL Library implementation built upon UEFI.
SAL Library implementation retrieving the SAL Entry Point from the SAL System Table
register in the EFI System Confguration Table.
Copyright (c) 2007 - 2008, Intel Corporation All rights
reserved. This program and the accompanying materials are
@@ -85,7 +86,7 @@ SalCall (
The constructor function looks up the SAL System Table in the EFI System Configuration
Table. Once the SAL System Table is found, the SAL Entry Point in the SAL System Table
will be derived and stored inot a global variable for library usage.
will be derived and stored into a global variable for library usage.
It will ASSERT() if the SAL System Table cannot be found or the data in the SAL System
Table is not the valid data.
@@ -114,9 +115,9 @@ UefiSalLibConstructor (
ASSERT_EFI_ERROR (Status);
//
// Move the SAL System Table point to the first Entry
// Due to the SAL Entry is in ascending order with the Entry type,
// the type 0 Entry should be the first if exist.
// Check the first entry of SAL System Table,
// because the SAL entry is in ascending order with the entry type,
// the type 0 entry should be the first if exist.
//
SalStEntryDes = (SAL_ST_ENTRY_POINT_DESCRIPTOR *)(SalSystemTable + 1);
@@ -128,7 +129,7 @@ UefiSalLibConstructor (
mPlabel.EntryPoint = SalStEntryDes->SalProcEntry;
mPlabel.GP = SalStEntryDes->SalGlobalDataPointer;
//
// Make sure the EntryPoint has the real value
// Make sure the EntryPoint has the valid value
//
ASSERT ((mPlabel.EntryPoint != 0) && (mPlabel.GP != 0));

11
MdePkg/Library/UefiSalLib/UefiSalLib.inf
View File

@@ -1,10 +1,10 @@
# @file
# The library implements the UEFI SAL Library Class.
# UEFI Instance of SAL Library Class.
#
# The library implements the UEFI SAL Library Class.
# This library is for boot service only modules.
# This instance of SAL library retrieves the SAL Entry Point from the SAL System Table
# register in the EFI System Confguration Table.
#
# Copyright (c) 2007, Intel Corporation.
# Copyright (c) 2007 - 2008, Intel Corporation.
#
# All rights reserved. This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
@@ -21,7 +21,7 @@
BASE_NAME = UefiSalLib
FILE_GUID = 4ABCFD77-4A33-4089-B003-5F09BCA940A2
MODULE_TYPE = UEFI_DRIVER
VERSION_STRING = 1.04
VERSION_STRING = 1.0
LIBRARY_CLASS = SalLib|UEFI_DRIVER UEFI_APPLICATION
EDK_RELEASE_VERSION = 0x00020000
EFI_SPECIFICATION_VERSION = 0x00020000
@@ -41,5 +41,4 @@
[LibraryClasses]
UefiLib
BaseLib
DebugLib