sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ShellPkg/Library: Fix 32-bit truncation of pointer values

Browse Source 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4366

Update C and UNI files that are incorrectly using %x or %08x
instead of %p for pointer values.  On 64-bit systems, this is
truncating pointer values above 4GB.

In reviewing ShellPkg for this issue some unused UNI strings
with incorrect format specifiers were removed instead of being
fixed.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
This commit is contained in:
Michael D Kinney
2023-03-11 11:31:51 -08:00
committed by mergify[bot]
parent d2bfe28966
commit e4c1d8d231
5 changed files with 12 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
View File

@@ -173,7 +173,7 @@
#string STR_HII #language en-US "HII"
#string STR_HII_FORM_CALLBACK #language en-US "HIICallback"
#string STR_TXT_OUT_DUMP_HEADER #language en-US " Address: %%H%X%%N Attrib %02x"
#string STR_TXT_OUT_DUMP_HEADER #language en-US " Address: %%H%p%%N Attrib %02x"
#string STR_TXT_OUT_DUMP_LINE #language en-US "\r\n %c mode %d: Col %d Row %d"
#string STR_DRIVER_FAM_OVERRIDE #language en-US "DriverFamilyOverride"
@@ -361,7 +361,7 @@
#string STR_DEBUGSUPPORT_INFO #language en-US " Isa = %s"
#string STR_DEBUGSUPPORT_UNKNOWN #language en-US " Unknown (%%H%s%%N)"
#string STR_PCIRB_DUMP_PH #language en-US " ParentHandle..: %%H%x%%N\r\n"
#string STR_PCIRB_DUMP_PH #language en-US " ParentHandle..: %%H%p%%N\r\n"
#string STR_PCIRB_DUMP_SEG #language en-US " Segment #.....: %%H%x%%N\r\n"
#string STR_PCIRB_DUMP_ATT #language en-US " Attributes....: %%H%x%%N\r\n"
#string STR_PCIRB_DUMP_SUPPORTS #language en-US " Supports......: %%H%x%%N\r\n"
@@ -375,7 +375,7 @@
" Device #......: %02x\r\n"
" Function #....: %02x\r\n"
" ROM Size......: %lx\r\n"
" ROM Location..: %08x\r\n"
" ROM Location..: %p\r\n"
" Vendor ID.....: %04x\r\n"
" Device ID.....: %04x\r\n"
" Class Code....: %02x %02x %02x\r\n"
@@ -388,18 +388,18 @@
#string STR_LI_DUMP_NAME #language en-US " Name..........: %%H%s%%N\r\n"
#string STR_LI_DUMP_MAIN #language en-US " Revision......: %%H0x%08x%%N\r\n"
" ParentHandle..: %%H%x%%N\r\n"
" SystemTable...: %%H%x%%N\r\n"
" DeviceHandle..: %%H%x%%N\r\n"
" ParentHandle..: %%H%p%%N\r\n"
" SystemTable...: %%H%p%%N\r\n"
" DeviceHandle..: %%H%p%%N\r\n"
" FilePath......: %%H%s%%N\r\n"
" PdbFileName...: %%H%a%%N\r\n"
" OptionsSize...: %%H%x%%N\r\n"
" LoadOptions...: %%H%x%%N\r\n"
" ImageBase.....: %%H%x%%N\r\n"
" LoadOptions...: %%H%p%%N\r\n"
" ImageBase.....: %%H%p%%N\r\n"
" ImageSize.....: %%H%Lx%%N\r\n"
" CodeType......: %%H%s%%N\r\n"
" DataType......: %%H%s%%N\r\n"
" Unload........: %%H%x%%N"
" Unload........: %%H%p%%N"
#string STR_GOP_DUMP_MAIN #language en-US " Max Mode..............: %%H0x%08x%%N\r\n"
" Current Mode..........: %%H0x%08x%%N\r\n"