sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ShellPkg: Add checks for NULL pointers.

Browse Source 
This adds lots of pointer verification with ASSERTs only used when the condition should be impossible and never for memory allocation.

signed-off-by: jcarsey
reviewed-by: geekboy15a

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12523 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
jcarsey
2011-10-10 20:32:17 +00:00
parent beab0fc5e2
commit ecae51177e
9 changed files with 56 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
View File

@ -206,8 +206,10 @@ TxtOutProtocolDumpInformation(
RetVal = AllocateZeroPool(Size);
Temp = HiiGetString(mHandleParsingHiiHandle, STRING_TOKEN(STR_TXT_OUT_DUMP_HEADER), NULL);
UnicodeSPrint(RetVal, Size, Temp, Dev, Dev->Mode->Attribute);
FreePool(Temp);
if (Temp != NULL) {
UnicodeSPrint(RetVal, Size, Temp, Dev, Dev->Mode->Attribute);
FreePool(Temp);
}
//
// Dump TextOut Info
@ -219,7 +221,7 @@ TxtOutProtocolDumpInformation(
UnicodeSPrint(
RetVal + StrLen(RetVal),
NewSize,
Temp,
Temp == NULL?L"":Temp,
Index == Dev->Mode->Mode ? L'*' : L' ',
Index,
!EFI_ERROR(Status)?Col:-1,