sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

FmpDevicePkg FmpDxe: Use Attributes to know whether reset is required

Browse Source 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1040

Use Attributes to know whether reset is required and remove
PcdFmpDeviceSystemResetRequired.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
This commit is contained in:
Star Zeng
2018-07-18 19:00:32 +08:00
committed by Kinney, Michael D
parent ebfac291bd
commit f1a921cab2
5 changed files with 10 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
FmpDevicePkg/FmpDxe/FmpDxe.c
View File

@@ -898,6 +898,9 @@ SetTheImage (
UINT32 AllHeaderSize;
UINT32 IncommingFwVersion;
UINT32 LastAttemptStatus;
EFI_STATUS GetAttributesStatus;
UINT64 AttributesSupported;
UINT64 AttributesSetting;
Status = EFI_SUCCESS;
Updateable = 0;
@@ -1110,10 +1113,14 @@ SetTheImage (
//
// Set flag so the descriptor is repopulated
// This only applied to devices that do not require system reboot
// This is only applied to devices that do not require reset
//
if (!PcdGetBool (PcdFmpDeviceSystemResetRequired)) {
mDescriptorPopulated = FALSE;
GetAttributesStatus = FmpDeviceGetAttributes (&AttributesSupported, &AttributesSetting);
if (!EFI_ERROR (GetAttributesStatus)) {
if (((AttributesSupported & IMAGE_ATTRIBUTE_RESET_REQUIRED) == 0) ||
((AttributesSetting & IMAGE_ATTRIBUTE_RESET_REQUIRED) == 0)) {
mDescriptorPopulated = FALSE;
}
}
cleanup: