sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

RedfishPkg: Redfish functions for REST requests are not fully spec complied

Browse Source 
There is no function to send POST request with the
ContentType different from "application\json".
There is no function to send DELETE request with the body.

Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Signed-off-by: Igor Kulchytskyy <igork@ami.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>
This commit is contained in:
Abner Chang
2022-08-23 10:09:37 +08:00
committed by mergify[bot]
parent eebef1b3b7
commit f2bf043aaa
4 changed files with 309 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c
View File

@ -924,9 +924,10 @@ ON_EXIT:
}
json_t *
deleteUriFromService (
deleteUriFromServiceEx (
redfishService *service,
const char *uri,
const char *content,
EFI_HTTP_STATUS_CODE **StatusCode
)
{
@ -937,6 +938,8 @@ deleteUriFromService (
EFI_HTTP_REQUEST_DATA *RequestData = NULL;
EFI_HTTP_MESSAGE *RequestMsg = NULL;
EFI_HTTP_MESSAGE ResponseMsg;
CHAR8 ContentLengthStr[80];
size_t contentLength;
ret = NULL;
@ -956,7 +959,7 @@ deleteUriFromService (
//
// Step 1: Create HTTP request message with 4 headers:
//
HttpIoHeader = HttpIoCreateHeader ((service->sessionToken || service->basicAuthStr) ? 5 : 4);
HttpIoHeader = HttpIoCreateHeader ((service->sessionToken || service->basicAuthStr) ? 8 : 7);
if (HttpIoHeader == NULL) {
ret = NULL;
goto ON_EXIT;
@ -979,6 +982,23 @@ deleteUriFromService (
Status = HttpIoSetHeader (HttpIoHeader, "Connection", "Keep-Alive");
ASSERT_EFI_ERROR (Status);
Status = HttpIoSetHeader (HttpIoHeader, "Content-Type", "application/json");
ASSERT_EFI_ERROR (Status);
if (content != NULL) {
contentLength = strlen (content);
AsciiSPrint (
ContentLengthStr,
sizeof (ContentLengthStr),
"%lu",
(UINT64)contentLength
);
Status = HttpIoSetHeader (HttpIoHeader, "Content-Length", ContentLengthStr);
ASSERT_EFI_ERROR (Status);
Status = HttpIoSetHeader (HttpIoHeader, "OData-Version", "4.0");
ASSERT_EFI_ERROR (Status);
}
//
// Step 2: build the rest of HTTP request info.
//
@ -1004,6 +1024,11 @@ deleteUriFromService (
RequestMsg->HeaderCount = HttpIoHeader->HeaderCount;
RequestMsg->Headers = HttpIoHeader->Headers;
if (content != NULL) {
RequestMsg->BodyLength = contentLength;
RequestMsg->Body = (VOID *)content;
}
ZeroMem (&ResponseMsg, sizeof (ResponseMsg));
//
@ -1057,6 +1082,16 @@ ON_EXIT:
return ret;
}
json_t *
deleteUriFromService (
redfishService *service,
const char *uri,
EFI_HTTP_STATUS_CODE **StatusCode
)
{
return deleteUriFromServiceEx (service, uri, NULL, StatusCode);
}
redfishPayload *
getRedfishServiceRoot (
redfishService *service,