sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MdeModulePkg/DxeHttpLib: Avoid the potential memory leak when error happen.

Browse Source 
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Wang Fan <fan.wang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
This commit is contained in:
Jiaxin Wu
2017-12-21 14:36:12 +08:00
parent b2a73b5b3c
commit f5168b847d
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
View File

@ -372,6 +372,8 @@ HttpParseUrl (
BOOLEAN FoundAt; BOOLEAN FoundAt;
EFI_STATUS Status; EFI_STATUS Status;
HTTP_URL_PARSER *Parser; HTTP_URL_PARSER *Parser;
Parser = NULL;
if (Url == NULL || Length == 0 || UrlParser == NULL) { if (Url == NULL || Length == 0 || UrlParser == NULL) {
return EFI_INVALID_PARAMETER; return EFI_INVALID_PARAMETER;
@ -402,6 +404,7 @@ HttpParseUrl (
switch (State) { switch (State) {
case UrlParserStateMax: case UrlParserStateMax:
FreePool (Parser);
return EFI_INVALID_PARAMETER; return EFI_INVALID_PARAMETER;
case UrlParserSchemeColon: case UrlParserSchemeColon:
@ -464,6 +467,7 @@ HttpParseUrl (
if ((Parser->FieldBitMap & BIT (HTTP_URI_FIELD_AUTHORITY)) != 0) { if ((Parser->FieldBitMap & BIT (HTTP_URI_FIELD_AUTHORITY)) != 0) {
Status = NetHttpParseAuthority (Url, FoundAt, Parser); Status = NetHttpParseAuthority (Url, FoundAt, Parser);
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
FreePool (Parser);
return Status; return Status;
} }
} }
@ -1528,6 +1532,7 @@ HttpSetFieldNameAndValue (
FieldValueSize = AsciiStrSize (FieldValue); FieldValueSize = AsciiStrSize (FieldValue);
HttpHeader->FieldValue = AllocateZeroPool (FieldValueSize); HttpHeader->FieldValue = AllocateZeroPool (FieldValueSize);
if (HttpHeader->FieldValue == NULL) { if (HttpHeader->FieldValue == NULL) {
FreePool (HttpHeader->FieldName);
return EFI_OUT_OF_RESOURCES; return EFI_OUT_OF_RESOURCES;
} }
CopyMem (HttpHeader->FieldValue, FieldValue, FieldValueSize); CopyMem (HttpHeader->FieldValue, FieldValue, FieldValueSize);